List:Commits« Previous MessageNext Message »
From:Hakan Kuecuekyilmaz Date:July 17 2008 2:13pm
Subject:Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)
View as plain text  
On Do, 2008-07-17 at 16:53 +0300, Andrey Hristov wrote:
> Hakan Kuecuekyilmaz wrote:
> > On Do, 2008-07-17 at 14:37 +0200, Vladislav Vaintroub wrote:
> >>> -----Original Message-----
> >>> From: Hakan Kuecuekyilmaz [mailto:hakan@stripped]
> >>> Sent: Thursday, July 17, 2008 12:42 PM
> >>> To: commits@stripped
> >>> Subject: bzr commit into mysql-6.0-falcon branch (hakan:2750)
> >> Thanks for reviving tests.
> >> I'm curious about changes were  to 37080, could you elaborate?
> >>
> >>> +++ b/mysql-test/suite/falcon/t/falcon_bug_37080.test	2008-07-16
> >>  
> >>>  --disable_warnings
> >>> -DROP TABLE IF EXISTS t;
> >>> +DROP TABLE IF EXISTS t1;
> >> Why 't1' ? Is 't' not good enough?
> > 
> > t1 is standard name for test tables like t1, t2, t3, t4, ..., tn
> 
> I would suggest you don't use t1, t2 for tests that are bug related but 
> include the bug number in the table name..like t37080_1 , t37080_2 and 
> so on. Creates less confusion and makes finding of collision effects 
> easier (when one test fails, doesn't clean properly, tables like t1 etc.).

Ja, ja -- that's like IE starting to interpret completely broken HTML
into something.

After having unique tables names and no conflicts happening anymore,
tests with side effects will increase. I am definitely against that.


-- 
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160
98953296
Sun Microsystems GmbH     Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer:  Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering   HRB MUC 161028     49.011, 8.376

Thread
bzr commit into mysql-6.0-falcon branch (hakan:2750) Hakan Kuecuekyilmaz17 Jul
  • RE: bzr commit into mysql-6.0-falcon branch (hakan:2750) Vladislav Vaintroub17 Jul
    • RE: bzr commit into mysql-6.0-falcon branch (hakan:2750)Hakan Kuecuekyilmaz17 Jul
      • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Andrey Hristov17 Jul
        • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Hakan Kuecuekyilmaz17 Jul
RE: bzr commit into mysql-6.0-falcon branch (hakan:2750)Hakan Kuecuekyilmaz17 Jul
  • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Andrey Hristov17 Jul
    • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Hakan Kuecuekyilmaz17 Jul
      • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Andrey Hristov17 Jul
      • Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)Andrey Hristov17 Jul