Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)

[Andrey Hristov]

Hakan Kuecuekyilmaz wrote:
> On Do, 2008-07-17 at 14:37 +0200, Vladislav Vaintroub wrote:
>>> -----Original Message-----
>>> From: Hakan Kuecuekyilmaz [mailto:hakan@stripped]
>>> Sent: Thursday, July 17, 2008 12:42 PM
>>> To: commits@stripped
>>> Subject: bzr commit into mysql-6.0-falcon branch (hakan:2750)
>> Thanks for reviving tests.
>> I'm curious about changes were  to 37080, could you elaborate?
>>
>>> +++ b/mysql-test/suite/falcon/t/falcon_bug_37080.test	2008-07-16
>>  
>>>  --disable_warnings
>>> -DROP TABLE IF EXISTS t;
>>> +DROP TABLE IF EXISTS t1;
>> Why 't1' ? Is 't' not good enough?
> 
> t1 is standard name for test tables like t1, t2, t3, t4, ..., tn

I would suggest you don't use t1, t2 for tests that are bug related but 
include the bug number in the table name..like t37080_1 , t37080_2 and 
so on. Creates less confusion and makes finding of collision effects 
easier (when one test fails, doesn't clean properly, tables like t1 etc.).

> 
>>>  --enable_warnings
>>>
>>> -
>>> -CREATE TABLE t(i int);
>>> +CREATE TABLE t1(a int);
>> Why 'a' ? Is 'i' not good enough?
> 
> a is standard name for fields like a, b, c, d, ...
> 
> 
> 
>>> -   --send insert into t values(1);
>>> +   --send insert into t1 values(1), (3), (5), (7) , (11);
>> Why many values instead of one?
> 
> That's because I wanted to see how many prime numbers I know by heart.
> 
> Best regards,
> 
> Hakan
> 

Andrey