MySQL Lists: commits: bzr commit into NDB/Bindings:trunk branch (monty:409)

List:	Commits	« Previous Message Next Message »
From:	Monty Taylor	Date:	July 16 2008 2:59pm
Subject:	bzr commit into NDB/Bindings:trunk branch (monty:409)
View as plain text
#At https://bazaar.launchpad.net/~ndb-bindings/ndb-bindings/trunk

  409 Monty Taylor	2008-07-16
      Fixed build warnings. As soon as upstream NDB API build warnings are fixed (just submitted the patch) we should be building clean.
modified:
  interface/mgmapi/NdbMgm.i
  interface/mgmapi/mgmglobals.i
  interface/ndbapi/Ndb.i
  interface/ndbapi/ndbglobals.i
  java/swig/ndb_exception.i
  mgmpp/NdbEventListener.hpp
  mgmpp/listeners.hpp
  ndbpp/libndbpp.h

=== modified file 'interface/mgmapi/NdbMgm.i'
--- a/interface/mgmapi/NdbMgm.i	2008-05-28 09:38:57 +0000
+++ b/interface/mgmapi/NdbMgm.i	2008-07-16 14:59:23 +0000
@@ -810,7 +810,7 @@ public:
   NdbLogEventManager *
     createNdbLogEventManager(const std::vector<NdbFilterItem> filter) {
 
-    int theFilter[filter.size()*2+1];
+    int * theFilter = (int *)malloc(filter.size()*2+1);
     for(unsigned x=0;x<filter.size();x++) {
       theFilter[x*2]=filter[x].level;
       theFilter[x*2+1]=(int)(filter[x].category);

=== modified file 'interface/mgmapi/mgmglobals.i'
--- a/interface/mgmapi/mgmglobals.i	2008-05-22 17:05:11 +0000
+++ b/interface/mgmapi/mgmglobals.i	2008-07-16 14:59:23 +0000
@@ -59,7 +59,7 @@
     CouldNotAbortBackup,
     CouldNotEnterSingleUserMode,
     CouldNotExitSigleUserMode,
-    UsageError,
+    UsageError
   };
 
   enum BackupStartOption {

=== modified file 'interface/ndbapi/Ndb.i'
--- a/interface/ndbapi/Ndb.i	2008-07-16 14:05:39 +0000
+++ b/interface/ndbapi/Ndb.i	2008-07-16 14:59:23 +0000
@@ -84,6 +84,8 @@ public:
       }
   }
   int init(int maxNoOfTransactions = 4) {
+    (void)$self;
+    (void)maxNoOfTransactions;
     /* This is becoming a no-op, since we're forcing it */
     return 0;
   }

=== modified file 'interface/ndbapi/ndbglobals.i'
--- a/interface/ndbapi/ndbglobals.i	2008-06-30 13:29:41 +0000
+++ b/interface/ndbapi/ndbglobals.i	2008-07-16 14:59:23 +0000
@@ -28,6 +28,7 @@
 
 %inline %{
   void dbugPush(const char * dbugString) {
+    (void)dbugString;
     DBUG_PUSH(dbugString);
   }
   %}

=== modified file 'java/swig/ndb_exception.i'
--- a/java/swig/ndb_exception.i	2008-04-19 18:53:30 +0000
+++ b/java/swig/ndb_exception.i	2008-07-16 14:59:23 +0000
@@ -55,6 +55,7 @@
 
   void ndb_throw_exception(JNIEnv *jenv, const char * excp,
                            const char *msg, NdbError & err) {
+    (void)msg;
     jclass clazz = NULL;
     const char * prefix = "com/mysql/cluster/ndbj/";
     if (strncmp(excp,"com.",4)==0) {

=== modified file 'mgmpp/NdbEventListener.hpp'
--- a/mgmpp/NdbEventListener.hpp	2008-03-11 13:55:15 +0000
+++ b/mgmpp/NdbEventListener.hpp	2008-07-16 14:59:23 +0000
@@ -27,18 +27,18 @@
 class NdbLogEventListener { 
 public: 
   virtual ~NdbLogEventListener() {} 
-  virtual void le_handleEvent(const ndb_logevent & event) {}
+  virtual void le_handleEvent(const ndb_logevent & event) {(void)event;}
 };
 class NdbLogEventCategoryListener { 
 public: 
   virtual ~NdbLogEventCategoryListener() {} 
-  virtual void le_handleEvent(const ndb_logevent & event) {}
+  virtual void le_handleEvent(const ndb_logevent & event) {(void)event;}
   virtual ndb_mgm_event_category getEventCategory() { return NDB_MGM_ILLEGAL_EVENT_CATEGORY; }
 };
 class NdbLogEventTypeListener { 
 public: 
   virtual ~NdbLogEventTypeListener() {} 
-  virtual void le_handleEvent(const ndb_logevent & event) {}
+  virtual void le_handleEvent(const ndb_logevent & event) {(void)event;}
   virtual Ndb_logevent_type getEventType() { return NDB_LE_ILLEGAL_TYPE; } 
   };
 

=== modified file 'mgmpp/listeners.hpp'
--- a/mgmpp/listeners.hpp	2008-02-16 17:04:54 +0000
+++ b/mgmpp/listeners.hpp	2008-07-16 14:59:23 +0000
@@ -32,7 +32,7 @@ private:
 	
 public:		    
     
-  virtual void handleEvent(ArbitResult * event) {};
+  virtual void handleEvent(ArbitResult * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -48,7 +48,7 @@ private:
 
 public:
 
-  virtual void handleEvent(ArbitState * event) {};
+  virtual void handleEvent(ArbitState * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -64,7 +64,7 @@ private:
 
 public:
 
-  virtual void handleEvent(BackupAborted * event) {};
+  virtual void handleEvent(BackupAborted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -78,7 +78,7 @@ private:
 
 public:
 
-  virtual void handleEvent(BackupCompleted * event) {};
+  virtual void handleEvent(BackupCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -92,7 +92,7 @@ private:
 
 public:
 
-  virtual void handleEvent(BackupFailedToStart * event) {};
+  virtual void handleEvent(BackupFailedToStart * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -106,7 +106,7 @@ private:
 
 public:
 
-  virtual void handleEvent(BackupStarted * event) {};
+  virtual void handleEvent(BackupStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -120,7 +120,7 @@ private:
 
 public:
 
-  virtual void handleEvent(CmRegConf * event) {};
+  virtual void handleEvent(CmRegConf * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -134,7 +134,7 @@ private:
 
 public:
 
-  virtual void handleEvent(CmRegRef * event) {};
+  virtual void handleEvent(CmRegRef * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -148,7 +148,7 @@ private:
 
 public:
 
-  virtual void handleEvent(CommunicationClosed * event) {};
+  virtual void handleEvent(CommunicationClosed * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -162,7 +162,7 @@ private:
 
 public:
 
-  virtual void handleEvent(CommunicationOpened * event) {};
+  virtual void handleEvent(CommunicationOpened * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -176,7 +176,7 @@ private:
 
 public:
 
-  virtual void handleEvent(ConnectedApiVersion * event) {};
+  virtual void handleEvent(ConnectedApiVersion * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -190,7 +190,7 @@ private:
 
 public:
 
-  virtual void handleEvent(CreateLogBytes * event) {};
+  virtual void handleEvent(CreateLogBytes * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -204,7 +204,7 @@ private:
 
 public:
 
-  virtual void handleEvent(DeadDueToHeartbeat * event) {};
+  virtual void handleEvent(DeadDueToHeartbeat * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -218,7 +218,7 @@ private:
 
 public:
 
-  virtual void handleEvent(Connected * event) {};
+  virtual void handleEvent(Connected * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -231,7 +231,7 @@ private:
 
 public:
 
-  virtual void handleEvent(Disconnected * event) {};
+  virtual void handleEvent(Disconnected * event) {(void)event;} ;
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -245,7 +245,7 @@ private:
 
 public:
 
-  virtual void handleEvent(EventBufferStatus * event) {};
+  virtual void handleEvent(EventBufferStatus * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -259,7 +259,7 @@ private:
 
 public:
 
-  virtual void handleEvent(FindNeighbours * event) {};
+  virtual void handleEvent(FindNeighbours * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -273,7 +273,7 @@ private:
 
 public:
 
-  virtual void handleEvent(GCPTakeoverCompleted * event) {};
+  virtual void handleEvent(GCPTakeoverCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -287,7 +287,7 @@ private:
 
 public:
 
-  virtual void handleEvent(GCPTakeoverStarted * event) {};
+  virtual void handleEvent(GCPTakeoverStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -301,7 +301,7 @@ private:
 
 public:
 
-  virtual void handleEvent(GlobalCheckpointCompleted * event) {};
+  virtual void handleEvent(GlobalCheckpointCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -315,7 +315,7 @@ private:
 
 public:
 
-  virtual void handleEvent(GlobalCheckpointStarted * event) {};
+  virtual void handleEvent(GlobalCheckpointStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -329,7 +329,7 @@ private:
 
 public:
 
-  virtual void handleEvent(InfoEvent * event) {};
+  virtual void handleEvent(InfoEvent * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -343,7 +343,7 @@ private:
 
 public:
 
-  virtual void handleEvent(JobStatistic * event) {};
+  virtual void handleEvent(JobStatistic * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -357,7 +357,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LCPFragmentCompleted * event) {};
+  virtual void handleEvent(LCPFragmentCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -371,7 +371,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LCPStoppedInCalcKeepGci * event) {};
+  virtual void handleEvent(LCPStoppedInCalcKeepGci * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -385,7 +385,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LCPTakeoverCompleted * event) {};
+  virtual void handleEvent(LCPTakeoverCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -399,7 +399,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LCPTakeoverStarted * event) {};
+  virtual void handleEvent(LCPTakeoverStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -413,7 +413,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LocalCheckpointCompleted * event) {};
+  virtual void handleEvent(LocalCheckpointCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -427,7 +427,7 @@ private:
 
 public:
 
-  virtual void handleEvent(LocalCheckpointStarted * event) {};
+  virtual void handleEvent(LocalCheckpointStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -441,7 +441,7 @@ private:
 
 public:
 
-  virtual void handleEvent(MemoryUsage * event) {};
+  virtual void handleEvent(MemoryUsage * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -455,7 +455,7 @@ private:
 
 public:
 
-  virtual void handleEvent(MissedHeartbeat * event) {};
+  virtual void handleEvent(MissedHeartbeat * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -469,7 +469,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStartCompleted * event) {};
+  virtual void handleEvent(NdbStartCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -483,7 +483,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStartStarted * event) {};
+  virtual void handleEvent(NdbStartStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -497,7 +497,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStopAborted * event) {};
+  virtual void handleEvent(NdbStopAborted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -511,7 +511,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStopCompleted * event) {};
+  virtual void handleEvent(NdbStopCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -525,7 +525,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStopForced * event) {};
+  virtual void handleEvent(NdbStopForced * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -539,7 +539,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NdbStopStarted * event) {};
+  virtual void handleEvent(NdbStopStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -553,7 +553,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NodeFailCompleted * event) {};
+  virtual void handleEvent(NodeFailCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -567,7 +567,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NodeFailReported * event) {};
+  virtual void handleEvent(NodeFailReported * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -581,7 +581,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NRCopyDict * event) {};
+  virtual void handleEvent(NRCopyDict * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -595,7 +595,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NRCopyDistr * event) {};
+  virtual void handleEvent(NRCopyDistr * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -609,7 +609,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NRCopyFragDone * event) {};
+  virtual void handleEvent(NRCopyFragDone * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -623,7 +623,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NRCopyFragsCompleted * event) {};
+  virtual void handleEvent(NRCopyFragsCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -637,7 +637,7 @@ private:
 
 public:
 
-  virtual void handleEvent(NRCopyFragsStarted * event) {};
+  virtual void handleEvent(NRCopyFragsStarted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -651,7 +651,7 @@ private:
 
 public:
 
-  virtual void handleEvent(OperationReportCounters * event) {};
+  virtual void handleEvent(OperationReportCounters * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -665,7 +665,7 @@ private:
 
 public:
 
-  virtual void handleEvent(ReceiveBytesStatistic * event) {};
+  virtual void handleEvent(ReceiveBytesStatistic * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -679,7 +679,7 @@ private:
 
 public:
 
-  virtual void handleEvent(SendBytesStatistic * event) {};
+  virtual void handleEvent(SendBytesStatistic * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -693,7 +693,7 @@ private:
 
 public:
 
-  virtual void handleEvent(SentHeartbeat * event) {};
+  virtual void handleEvent(SentHeartbeat * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -707,7 +707,7 @@ private:
 
 public:
 
-  virtual void handleEvent(SingleUser * event) {};
+  virtual void handleEvent(SingleUser * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -721,7 +721,7 @@ private:
 
 public:
 
-  virtual void handleEvent(StartLog * event) {};
+  virtual void handleEvent(StartLog * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -735,7 +735,7 @@ private:
 
 public:
 
-  virtual void handleEvent(StartPhaseCompleted * event) {};
+  virtual void handleEvent(StartPhaseCompleted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -749,7 +749,7 @@ private:
 
 public:
 
-  virtual void handleEvent(StartREDOLog * event) {};
+  virtual void handleEvent(StartREDOLog * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -763,7 +763,7 @@ private:
 
 public:
 
-  virtual void handleEvent(StartReport * event) {};
+  virtual void handleEvent(StartReport * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -777,7 +777,7 @@ private:
 
 public:
 
-  virtual void handleEvent(STTORRYRecieved * event) {};
+  virtual void handleEvent(STTORRYRecieved * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -791,7 +791,7 @@ private:
 
 public:
 
-  virtual void handleEvent(TableCreated * event) {};
+  virtual void handleEvent(TableCreated * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -805,7 +805,7 @@ private:
 
 public:
 
-  virtual void handleEvent(TransporterError * event) {};
+  virtual void handleEvent(TransporterError * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -819,7 +819,7 @@ private:
 
 public:
 
-  virtual void handleEvent(TransporterWarning * event) {};
+  virtual void handleEvent(TransporterWarning * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -833,7 +833,7 @@ private:
 
 public:
 
-  virtual void handleEvent(TransReportCounters * event) {};
+  virtual void handleEvent(TransReportCounters * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -847,7 +847,7 @@ private:
 
 public:
 
-  virtual void handleEvent(UndoLogBlocked * event) {};
+  virtual void handleEvent(UndoLogBlocked * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -861,7 +861,7 @@ private:
 
 public:
 
-  virtual void handleEvent(UNDORecordsExecuted * event) {};
+  virtual void handleEvent(UNDORecordsExecuted * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 
@@ -874,7 +874,7 @@ class WarningTypeListener : public NdbLo
  
 public:
 
-  virtual void handleEvent(Warning * event) {};
+  virtual void handleEvent(Warning * event) {(void)event;};
   void le_handleEvent(const ndb_logevent & event);
   Ndb_logevent_type getEventType();
 

=== modified file 'ndbpp/libndbpp.h'
--- a/ndbpp/libndbpp.h	2008-06-30 17:05:21 +0000
+++ b/ndbpp/libndbpp.h	2008-07-16 14:59:23 +0000
@@ -62,7 +62,7 @@ enum NdbException {
   UnknownErrorCode,
   NodeShutdown,
   SchemaObjectExists,
-  InternalTemporary,
+  InternalTemporary
 };
 
 long long getMicroTime();
Thread
• bzr commit into NDB/Bindings:trunk branch (monty:409)	Monty Taylor	16 Jul