bzr commit into mysql-5.1 branch (gshchepa:2704) Bug#37761

[Gleb Shchepa]

#At file:///work/bzr/mysql-5.1-bugteam-gca/

 2704 Gleb Shchepa	2008-07-15
      after-push patch: partial rollback of bug #37761 fix.
      
      Note: item->null_value is not updated before a call to
      item->store(), item->is_null() is not too (in common case).
modified:
  sql/item_cmpfunc.cc

=== modified file 'sql/item_cmpfunc.cc'
--- a/sql/item_cmpfunc.cc	2008-07-14 09:06:49 +0000
+++ b/sql/item_cmpfunc.cc	2008-07-15 12:12:08 +0000
@@ -3758,8 +3758,6 @@ longlong Item_func_in::val_int()
     return (longlong) (!null_value && tmp != negated);
   }
 
-  if ((null_value= args[0]->null_value))
-    return 0;
   have_null= 0;
   for (uint i= 1 ; i < arg_count ; i++)
   {
@@ -3769,6 +3767,8 @@ longlong Item_func_in::val_int()
     if (!(value_added_map & (1 << (uint)cmp_type)))
     {
       in_item->store_value(args[0]);
+      if ((null_value= args[0]->null_value))
+        return 0;
       value_added_map|= 1 << (uint)cmp_type;
     }
     if (!in_item->cmp(args[i]) && !args[i]->null_value)