RE: bzr commit into mysql-6.0-backup branch (ingo.struewing:2662) Bug#38045

[Chuck Bell]

Ingo,

Patch approved with one minor change: 


> === modified file 'mysql-test/t/backup_myisam2.test'
> --- a/mysql-test/t/backup_myisam2.test	2008-07-02 
> 07:53:34 +0000
> +++ b/mysql-test/t/backup_myisam2.test	2008-07-14 
> 15:33:03 +0000
> @@ -75,14 +75,30 @@ SET DEBUG_SYNC= 'now SIGNAL bup_finish';
>  
>      disconnect backup;
>  
> +--echo
> +--echo connection default: cleanup
> +connection default;
> +--remove_file $MYSQLTEST_VARDIR/master-data/test.ba
> +SET DEBUG_SYNC= 'RESET';
> +
> +
> +--echo
> +--echo #
> +--echo # Bug#38045 - Backup, MyISAM and file system encoding 
> --echo # 
> +CREATE TABLE `äöüߣå` (id SERIAL) ENGINE=MyISAM; 
> --replace_column 1 # 
> +BACKUP DATABASE mysqltest TO 'test.ba'; DROP TABLE
> `äöüߣå`; 
> +--remove_file $MYSQLTEST_VARDIR/master-data/test.ba
> +
> +
>  #
>  # Cleanup from this test case
>  #
>  --echo
> ---echo connection default: cleanup
> -connection default;
> +--echo # final cleanup
>  USE test;
>  DROP DATABASE mysqltest;
> ---remove_file $MYSQLTEST_VARDIR/master-data/test.ba
>  SET DEBUG_SYNC= 'RESET';

Since you added a remove_file above, you need to add --error 0,1 to before
this last call to remove_file. Either that or take one of them out.

Chuck