Hi!
On Jul 11, Narayanan V wrote:
> #At
> file:///home/vn/work/mysql/workspaces-bazaar/main_tree_6.0_shared_repository_directory/mysql-6.0-1/
>
> 2676 Narayanan V 2008-07-11
> WL#4448
>
> The attached patch adds a method
> handlerton::fill_is_table that can be used
> instead of having to create specific
> handlerton::fill_*_table methods.
> === modified file 'sql/ha_ndbcluster.cc'
> --- a/sql/ha_ndbcluster.cc 2008-06-28 11:00:59 +0000
> +++ b/sql/ha_ndbcluster.cc 2008-07-11 13:08:06 +0000
> @@ -11497,6 +11502,29 @@ bool ha_ndbcluster::get_no_parts(const c
> DBUG_RETURN(TRUE);
> }
>
> +/**
> + Used to fill in INFORMATION_SCHEMA* tables.
> +
> + @param hton handle to the handlerton structure
> + @param thd the thread/connection descriptor
> + @param[in,out] tables the information schema table that is filled up
> + @param cond used for conditional pushdown to storage engine
> + @param schema_table_idx the table id that distinguishes the type of table
> +
> + @return Operation status
> + */
> +static int ndbcluster_fill_is_table(handlerton *hton,
> + THD *thd,
> + TABLE_LIST *tables,
> + COND *cond,
> + enum enum_schema_tables schema_table_idx)
> +{
> + if (schema_table_idx == SCH_FILES)
> + {
> + ndbcluster_fill_files_table(hton, thd, tables, cond);
> + }
> +}
you ignore the return value of ndbcluster_fill_files_table
> static int ndbcluster_fill_files_table(handlerton *hton,
> THD *thd,
> TABLE_LIST *tables,
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
