Re: bzr push into mysql-6.0-falcon branch (olav:2742 to 2743) Bug#37622

[Olav Sandstaa]

Hi Jörg;

Joerg Bruehe wrote:
>>> We once had problems with a Makefile macro whose final continuation 
>>> line was empty, as yours of "INCLUDES" will be in all cases where 
>>> "FALCON_SPARC_ASSEMBLY" is not set.
>>>
>>> I scanned my archive and found that was in the 5.0 community tree, 
>>> fix committed by me on 2007-11-15 for 5.0.51.
>>> Our central host "production" failed on that.
>>>
>>> The fix was to reorder the elements on the lines so that the last 
>>> line would always have some contents.
>>
>> Thanks for the information. Do you want me to make an updated patch 
>> where I have re-ordered the elements in the "INCLUDES" to avoid that 
>> this breaks something? Or should we "wait-and-see" if this still is a 
>> problem for some platform?
>
> I cannot say I "want", but IMO it would be a safeguard against us 
> hitting a "make" that has this problem.
> I assume it may be version-specific, or rely on sufficient blank lines 
> following, or whatever - all I know is that we hit it once, and solved 
> it by reordering.
>
> So yes, I would prefer to see that changed: "better safe than sorry".

I totally agree with you. I will make a follow-up patch for this 
(actually, when I first implemented this I had the FALCON_SPARC_ASSEMBLY 
earlier in the INCLUDES but moved it to the end *bacause* it did not 
look nice when it was intermixed in-between several -I options :-) ).

Regards,
Olav