From: Date: April 13 2006 10:12pm
Subject: bk commit into 5.0 tree (bell:1.2156) BUG#14308
List-Archive: http://lists.mysql.com/commits/4942
X-Bug: 14308
Message-Id: <20060413201233.30A30456007@sanja.is.com.ua>

Below is the list of changes that have just been committed into a local
5.0 repository of bell. When bell does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2156 06/04/13 23:12:26 bell@stripped +4 -0
  The check for recursive view definitions added. (BUG#14308)

  sql/sql_view.cc
    1.85 06/04/13 23:12:22 bell@stripped +19 -1
    The check of view recursion.

  sql/share/errmsg.txt
    1.63 06/04/13 23:12:22 bell@stripped +2 -0
    New error message about a recursive view.

  mysql-test/t/view.test
    1.141 06/04/13 23:12:22 bell@stripped +31 -0
    BUG#14308 test suite.

  mysql-test/r/view.result
    1.152 06/04/13 23:12:22 bell@stripped +23 -0
    BUG#14308 test suite.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	bell
# Host:	sanja.is.com.ua
# Root:	/home/bell/mysql/bk/work-5.0

--- 1.62/sql/share/errmsg.txt	2006-04-13 00:46:36 +03:00
+++ 1.63/sql/share/errmsg.txt	2006-04-13 23:12:22 +03:00
@@ -5613,3 +5613,5 @@
 	eng "AGGREGATE is not supported for stored functions"
 ER_MAX_PREPARED_STMT_COUNT_REACHED 42000
         eng "Can't create more than max_prepared_stmt_count statements (current value: %lu)"
+ER_VIEW_RECURSIVE
+        eng "`%-.64s`.`%-.64s` contain view recursion"

--- 1.151/mysql-test/r/view.result	2006-04-08 21:42:00 +03:00
+++ 1.152/mysql-test/r/view.result	2006-04-13 23:12:22 +03:00
@@ -2600,3 +2600,26 @@
 5	2005-01-04
 DROP VIEW v1;
 DROP TABLE t1;
+create table t1 (a int);
+create view v1 as select * from t1;
+create view v2 as select * from v1;
+drop table t1;
+rename table v2 to t1;
+select * from v1;
+ERROR HY000: `test`.`v1` contain view recursion
+drop view t1, v1;
+create table t1 (a int);
+create function f1() returns int
+begin
+declare mx int;
+select max(a) from t1 into mx;
+return mx;
+end//
+create view v1 as select f1() as a;
+create view v2 as select * from v1;
+drop table t1;
+rename table v2 to t1;
+select * from v1;
+ERROR HY000: Recursive stored functions and triggers are not allowed.
+drop function f1;
+drop view t1, v1;

--- 1.140/mysql-test/t/view.test	2006-04-08 21:42:00 +03:00
+++ 1.141/mysql-test/t/view.test	2006-04-13 23:12:22 +03:00
@@ -2454,3 +2454,34 @@
 
 DROP VIEW v1;
 DROP TABLE t1;
+
+#
+# BUG#14308: Recursive view definitions
+#
+# using view only
+create table t1 (a int);
+create view v1 as select * from t1;
+create view v2 as select * from v1;
+drop table t1;
+rename table v2 to t1;
+-- error ER_VIEW_RECURSIVE
+select * from v1;
+drop view t1, v1;
+# using SP function
+create table t1 (a int);
+delimiter //;
+create function f1() returns int
+begin
+  declare mx int;
+  select max(a) from t1 into mx;
+  return mx;
+end//
+delimiter ;//
+create view v1 as select f1() as a;
+create view v2 as select * from v1;
+drop table t1;
+rename table v2 to t1;
+-- error ER_SP_NO_RECURSION
+select * from v1;
+drop function f1;
+drop view t1, v1;

--- 1.84/sql/sql_view.cc	2006-03-28 14:06:18 +03:00
+++ 1.85/sql/sql_view.cc	2006-04-13 23:12:22 +03:00
@@ -771,6 +771,7 @@
   SELECT_LEX *end, *view_select;
   LEX *old_lex, *lex;
   Query_arena *arena, backup;
+  TABLE_LIST *top_view= table->top_table();
   int res;
   bool result;
   DBUG_ENTER("mysql_make_view");
@@ -798,6 +799,24 @@
     DBUG_RETURN(0);
   }
 
+  /* check loop via view definition */
+  for (TABLE_LIST *precedent= table->referencing_view;
+       precedent;
+       precedent= precedent->referencing_view)
+  {
+    if (precedent->view_name.length == table->table_name_length &&
+        precedent->view_db.length == table->db_length &&
+        my_strcasecmp(system_charset_info,
+                      precedent->view_name.str, table->table_name) == 0 &&
+        my_strcasecmp(system_charset_info,
+                      precedent->view_db.str, table->db) == 0)
+    {
+      my_error(ER_VIEW_RECURSIVE, MYF(0),
+               top_view->view_db.str, top_view->view_name.str);
+      DBUG_RETURN(TRUE);
+    }
+  }
+
   /*
     For now we assume that tables will not be changed during PS life (it
     will be TRUE as far as we make new table cache).
@@ -896,7 +915,6 @@
   }
   if (!res && !thd->is_fatal_error)
   {
-    TABLE_LIST *top_view= table->top_table();
     TABLE_LIST *view_tables= lex->query_tables;
     TABLE_LIST *view_tables_tail= 0;
     TABLE_LIST *tbl;