Re: bzr commit into mysql-5.1-rpl branch (hezx:2611) Bug#35542, Bug#31665

[Davi Arnaut]

Sinisa Milivojevic wrote:
> He Zhenxing writes:
>>>>>> @@ -49,8 +49,7 @@
>>>>>>
>>>>>>   LOGGER logger;
>>>>>>
>>>>>> -MYSQL_BIN_LOG mysql_bin_log;
>>>>>> -ulong sync_binlog_counter= 0;
>>>>>> +MYSQL_BIN_LOG mysql_bin_log(&sync_binlog_period);
>>>>> Note: there is no mutex or other form of lock protecting this
> variable.
>>>>> In the event that the ulong is split into several registers, the two
>>>>> parts might be read and written separately.
>>>>>
>>>> yes, will be fixed
>>> OK.
>>>
>
> He,
>
> Please, make all sync_... variables of the uint type. Why is there a
> need for more then 4 billion changes before a sync ???? uint will make
> the operations atomic.
>

Beware that this is not true when incrementing or decrementing the said 
variable.

-- Davi