Re: bzr commit into MySQL Storage Engine API team tree:mysql-5.1-sea branch (v.narayanan:2679) WL#4380

[Narayanan]

oops sorry, me bad, will fix this :(.

Narayanan

Sergei Golubchik wrote:
> Hi!
>
> On Jul 09, Narayanan V wrote:
>   
>> #At bzr+ssh://bk-internal.mysql.com/bzrroot/mysql-5.1-sea
>>
>>  2679 Narayanan V	2008-07-09
>>       WL#4380
>>       
>>       Modified the abi_check target to check for only
>>       mysql.h and plugin.h for now.
>> modified:
>>   Makefile.am
>>
>> per-file messages:
>>   Makefile.am
>>     added two targets,
>>     
>>     abi_check -     compiles without mysql_priv.h
>>     abi_check_all - compiles with mysql_priv.h
>> === modified file 'Makefile.am'
>> --- a/Makefile.am	2008-07-09 13:34:22 +0000
>> +++ b/Makefile.am	2008-07-09 17:19:38 +0000
>> @@ -273,20 +278,25 @@ PREPROCESSOR_C_HEADER=$(top_srcdir)/incl
>>  # to replace the old canons with the new ones.
>>  #
>>  
>> -abi_check:	$(PREPROCESSOR_C_HEADER)
>> -	 set -ex; \
>> -	 for file in $(PREPROCESSOR_C_HEADER); do \
>> -	         @CC@ -E -nostdinc -dI \
>> +abi_check:	$(API_PREPROCESSOR_HEADER)
>> +	make abi_headers="$^" do_abi_check
>> +
>> +abi_check_all:	$(TEST_PREPROCESSOR_HEADER)
>> +	make abi_headers="$^" do_abi_check
>> +
>> +do_abi_check:
>> +	set -ex; \
>> +	for file in $(abi_headers); do \
>> +	         gcc -E -nostdinc -dI \
>>  	                  -I$(top_srcdir)/include \
>>  	                  -I$(top_srcdir)/include/mysql \
>>  	                  -I$(top_srcdir)/sql \
>>  	                                 $$file 2>/dev/null | \
>> -	                  @SED@ -e '/^# /d' \
>> -	                            -e '/^[ 	]*$$/d' > $$file.out; \
>> -	                  @DIFF@ $$file.pp $$file.out; \
>> -	                  @RM@ $$file.out; \
>> -	 done
>> -	 touch $@
>> +	                  /bin/sed -e '/^# /d' \
>> +	                           -e '/^[     ]*$$/d' > $$file.out; \
>> +	                  /usr/bin/diff -u $$file.pp $$file.out; \
>> +	                  /bin/rm $$file.out; \
>> +	done
>>     
>
> Uh-oh. Why did you replace @CC@, @SED@, @DIFF@, and @RM@ with gcc, sed,
> diff, rm ?
>
> You've copied my example verbatim, I guess :(
> Please put these @...@ variables back.
>
> Thanks.
>   
> Regards / Mit vielen Grüssen,
> Sergei
>
>