Sergei Golubchik wrote:
> Hi!
>
> 1. Why two separate commits (in 5.1 and 6.0) ?
>
I thought every push should be first accompanied by a gcommit. Since I
will be pushing into
5.1 and 6.0 did a commit for each tree.
> 2. you can make two rules like this (tested):
>
> API_PREPROCESSOR_HEADERS = $(top_srcdir)/include/mysql/plugin.h \
> $(top_srcdir)/include/mysql.h
> TEST_PREPROCESSOR_HEADERS = $(top_srcdir)/include/mysql/plugin.h \
> $(top_srcdir)/sql/mysql_priv.h \
> $(top_srcdir)/include/mysql.h
>
> abi_check: $(API_PREPROCESSOR_HEADERS)
> make abi_headers="$^" do_abi_check
>
> abi_check_all: $(TEST_PREPROCESSOR_HEADERS)
> make abi_headers="$^" do_abi_check
>
> do_abi_check:
> set -ex; \
> for file in $(abi_headers); do \
> gcc -E -nostdinc -dI \
> -I$(top_srcdir)/include \
> -I$(top_srcdir)/include/mysql \
> -I$(top_srcdir)/sql \
> $$file 2>/dev/null | \
> /bin/sed -e '/^# /d' \
> -e '/^[ ]*$$/d' > $$file.out; \
> /usr/bin/diff -u $$file.pp $$file.out; \
> /bin/rm $$file.out; \
> done
>
If you want two rules, yes I can try this. But, one of them will need to
be removed at a later stage. Then we would
need only the abi_check rule. We would not need this bifurcation then.
> On Jul 09, Narayanan V wrote:
>
>> 2659 Narayanan V 2008-07-09
>> WL#4380
>>
>> Modified the abi_check target to check for only
>> mysql.h and plugin.h for now.
>> modified:
>> Makefile.am
>>
>> per-file messages:
>> Makefile.am
>> Added a new variable API_PREPROCESSOR_HEADER that
>> contains only mysql.h and plugin.h.
>>
>> Modified the abi_check rule to use API_PREPROCESSOR_HEADER
>> instead of PREPROCESSOR_C_HEADER
>>
>
> Regards / Mit vielen Grüssen,
> Sergei
>
>
