From: Date: July 3 2008 1:03pm
Subject: bzr commit into mysql-6.0-falcon branch (lars-erik.bjork:2723) Bug#36991
List-Archive: http://lists.mysql.com/commits/48955
X-Bug: 36991
Message-Id: <200807031103.m63B3c0c029972@dm-norway-02.uk.sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

#At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-falcon/

 2723 lars-erik.bjork@stripped	2008-07-03
      bug#36991 falcon_max_transaction_backlog has no effect
      
      I have changed the maxTransactionBacklog to 1000 and have made the value unconfigurable.
modified:
  storage/falcon/Configuration.cpp
  storage/falcon/StorageParameters.h

per-file messages:
  storage/falcon/Configuration.cpp
    Using the same value for maxTransactionBacklog both when STORAGE_ENGINE is defined and when it is not. Changing this value from 10000 to 1000
  storage/falcon/StorageParameters.h
    Avoid creating a sysvar for falcon_max_transaction_backlog
=== modified file 'storage/falcon/Configuration.cpp'
--- a/storage/falcon/Configuration.cpp	2008-06-26 13:30:24 +0000
+++ b/storage/falcon/Configuration.cpp	2008-07-03 11:03:32 +0000
@@ -99,7 +99,7 @@ static const uint64 MIN_PAGE_CACHE			= 2
 static const uint64 MIN_RECORD_MEMORY		= 5000000;
 static const int	MIN_SCAVENGE_THRESHOLD	= 10;
 static const int	MIN_SCAVENGE_FLOOR		= 10;
-static const uint64 MAX_TRANSACTION_BACKLOG	= 10000;
+static const uint64 MAX_TRANSACTION_BACKLOG	= 1000;
 
 //////////////////////////////////////////////////////////////////////
 // Construction/Destruction
@@ -110,6 +110,7 @@ Configuration::Configuration(const char 
 	checkpointSchedule = "7,37 * * * * *";
 	scavengeSchedule = "15,45 * * * * *";
 	serialLogBlockSize			= falcon_serial_log_block_size;
+	maxTransactionBacklog		        = MAX_TRANSACTION_BACKLOG;
 
 #ifdef STORAGE_ENGINE
 	recordMemoryMax				= falcon_record_memory_max;
@@ -121,7 +122,6 @@ Configuration::Configuration(const char 
 	pageCacheSize				= falcon_page_cache_size;
 	indexChillThreshold			= falcon_index_chill_threshold;
 	recordChillThreshold		= falcon_record_chill_threshold;
-	maxTransactionBacklog		= falcon_max_transaction_backlog;
 	useDeferredIndexHash		= (falcon_use_deferred_index_hash != 0);
 	
 	if (falcon_checkpoint_schedule)
@@ -169,7 +169,6 @@ Configuration::Configuration(const char 
 	pageCacheSize				= getMemorySize(PAGE_CACHE_MEMORY);
 	indexChillThreshold			= 4 * ONE_MB;
 	recordChillThreshold		= 5 * ONE_MB;
-	maxTransactionBacklog		= MAX_TRANSACTION_BACKLOG;
 	falcon_lock_wait_timeout	= 0;
 #endif
 

=== modified file 'storage/falcon/StorageParameters.h'
--- a/storage/falcon/StorageParameters.h	2008-06-26 13:30:24 +0000
+++ b/storage/falcon/StorageParameters.h	2008-07-03 11:03:32 +0000
@@ -21,7 +21,6 @@ PARAMETER_UINT(index_chill_threshold, "B
 PARAMETER_UINT(io_threads, "Number of Falcon I/O threads", 2, 2, 20, 0, NULL)
 PARAMETER_UINT(large_blob_threshold, "Threshold for large blobs", 0, 160000, INT_MAX, 0, NULL)
 PARAMETER_UINT(lock_wait_timeout, "Transaction lock time period (seconds)", 0, 50, INT_MAX, 0, NULL)
-PARAMETER_UINT(max_transaction_backlog, "Maximum number of backlogged transactions.", 1, 150, 1000000, 0, NULL)
 PARAMETER_UINT(page_size, "The page size used when creating a Falcon tablespace.", 1024, 4096, 32768, 0x0200, NULL)
 PARAMETER_UINT(record_chill_threshold, "Bytes of pending record data that is 'frozen' to the Falcon serial log.", 1, 5*1024*1024, 1024*1024*1024, 0, &updateRecordChillThreshold)
 PARAMETER_UINT(record_scavenge_floor, "A percentage of falcon_record_memory_threshold that defines the amount of record data that will remain in the record cache after a scavenge run.", 10, 50, 90, 0x2000, &StorageInterface::updateRecordScavengeFloor)