Hi,
Please see my comments inline.
> Also, BUG#35249 is 'patch queued' so you must remove the code
> in the triggers test that disables the memory run.
>
> > --replace_result $ENGINE ENGINE
> > eval SELECT '$ENGINE'='memory';
> > if(`SELECT '$ENGINE'='memory'`)
> > {
> > skip Temporarily Disabled Bug#35249 ; }
>
> One more thing... I see that it is now impossible to run
> these tests on a system that has only MyISAM built. The tests
> are designed so that one has to have innodb, falcon, myisam,
> and memory storage engines built/installed in order to run
> the tests. I wonder if that is such a good idea?
>
Hema: It is always possible to remove the engines from the combinations file
and run the tests with the specific engine types.I don't see the necessity
of removing have_falcon and have_innodb. Please advice and I push the patch
once I get your approval.
Thanks,
Hema.S
> I think maybe you need to remove the have_falcon,
> have_innodb, etc. and handle it like you do above with the
> engines thing. Only please make a more informative message.
> 'Temporarily disabled' sounds like it is disabled as in
> disabled.def file but it isn't. In this case, you should
> print a message like 'Test skipped. No InnoDB support.'
>
> Chuck
>
>
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe: http://lists.mysql.com/commits?unsub=1
>
>
