Re: bzr commit into mysql-6.0 branch (alik:2652) WL#4435

[Konstantin Osipov]

* Alexander Nozdrin <alik@stripped> [08/06/17 12:17]:

Generally looks good, but I suggest to change a few things:

 - to send out parameters, you should reuse class Protocol
   functionality, instead of the current copy-paste
 - Out_param_info should be an interface that is implemented
 by sp_head/sp_rcontext (this needs to be thought through
 carefully, to ensure that sp_rcontext is still valid when data
 is sent out), 
 - instead of ps_add_out_parameter one should assign value
   directly to Item_param, and then, at the end of execution of a
   prepared statement, send the array of parameters out by means
   of a protocol method. The protocol is remembered in
   stmt->protocol, and text protocol implementation of
   send_out_parameters() should assign values
   to the variables.

Let's discuss on the phone the details of these steps.

--