Re: bzr commit into mysql-5.0 tree (marc.alff:2641) Bug#35577

[Sergei Golubchik]

Hi!

On Jun 23, Marc Alff wrote:
> #At file:///home/malff/BZR-TREE/mysql-5.0-35577/
> 
> ------------------------------------------------------------
> revno: 2641
> revision-id: marc.alff@stripped
> parent: mleich@stripped
> committer: Marc Alff <marc.alff@stripped>
> branch nick: mysql-5.0-35577
> timestamp: Mon 2008-06-23 17:17:12 -0600
> message:
>   Bug#35577 (CREATE PROCEDURE causes either crash or syntax error depending on
>   build)
>   
> === modified file 'sql/sp.cc'
> --- a/sql/sp.cc	2008-05-15 23:13:24 +0000
> +++ b/sql/sp.cc	2008-06-23 23:17:12 +0000
> @@ -443,8 +443,8 @@
>      goto end;
>  
>    {
> -    Lex_input_stream lip(thd, defstr.c_ptr(), defstr.length());
> -    thd->m_lip= &lip;
> +    Parser_state parser_state(thd, defstr.c_ptr(), defstr.length());
> +    thd->m_parser_state= &parser_state;
>      lex_start(thd);

Same issue, mentioned in my first review, setting thd's property to a
frame local variable.

Otherwise everything's ok.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring