List:Commits« Previous MessageNext Message »
From:He Zhenxing Date:June 27 2008 9:32am
Subject:Re: bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635)
WL#4398
View as plain text  
Hi,

Sergei Golubchik wrote:
> Hi!
> 
> On Jun 26, He Zhenxing wrote:
> > #At file:///media/sda3/work/mysql/bzrwork/semisync/mysql-6.0-semi-sync-1.0/
> > 
> >  2635 He Zhenxing	2008-06-26
> >       WL#4398 Replication Interface for semi-synchronous replication
> >       
> >       Add replication interface and plugin support
> 
> > === modified file 'sql/sql_plugin.cc'
> > --- a/sql/sql_plugin.cc	2008-04-14 10:15:04 +0000
> > +++ b/sql/sql_plugin.cc	2008-06-26 14:22:39 +0000
> > @@ -20,14 +20,6 @@
> >  #define REPORT_TO_LOG  1
> >  #define REPORT_TO_USER 2
> >  
> > -#ifdef DBUG_OFF
> > -#define plugin_ref_to_int(A) A
> > -#define plugin_int_to_ref(A) A
> > -#else
> > -#define plugin_ref_to_int(A) (A ? A[0] : NULL)
> > -#define plugin_int_to_ref(A) &(A)
> > -#endif
> > -
> >  extern struct st_mysql_plugin *mysqld_builtins[];
> >  
> >  char *opt_plugin_load= NULL;
> 
> > === modified file 'sql/sql_plugin.h'
> > --- a/sql/sql_plugin.h	2007-06-12 15:41:56 +0000
> > +++ b/sql/sql_plugin.h	2008-06-26 14:22:39 +0000
> > @@ -18,6 +18,14 @@
> >  
> >  class sys_var;
> >  
> > +#ifdef DBUG_OFF
> > +#define plugin_ref_to_int(A) A
> > +#define plugin_int_to_ref(A) A
> > +#else
> > +#define plugin_ref_to_int(A) (A ? A[0] : NULL)
> > +#define plugin_int_to_ref(A) &(A)
> > +#endif
> 
> You shouldn't need it - these macros are *internal* to sql_plugin.cc
> Why you don't use plugin_decl/plugin_dlib/ etc ?
> 

I need to use it with my_plugin_lock in rpl_handler.cc, otherwise, I
have to define something similar in it.

> Regards / Mit vielen Grüssen,
> Sergei
> 

Thread
bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635) WL#4398He Zhenxing26 Jun
  • Re: bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635)WL#4398Sergei Golubchik27 Jun
    • Re: bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635)WL#4398He Zhenxing27 Jun
      • Re: bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635)WL#4398Sergei Golubchik27 Jun
        • Re: bzr commit into mysql-6.0-semi-sync-1.0 branch (hezx:2635)WL#4398He Zhenxing27 Jun