Svoj,
I have a question: Why wasn't there a low level design done for the worklog?
I approve the patch pending the following changes and your implementation of
Rafal's requests to his satisfaction.
Chuck
> +RESTORE FROM 'db2.bak.gz';
> +backup_id
> +4
This is a bug. See below.
> +SHOW TABLES FROM db1;
> +Tables_in_db1
> +t1
> +t2
> +DROP DATABASE db1;
>
> === added file 'mysql-test/t/backup_compression.test'
> --- a/mysql-test/t/backup_compression.test 1970-01-01
> 00:00:00 +0000
> +++ b/mysql-test/t/backup_compression.test 2008-06-16
> 15:06:09 +0000
> @@ -0,0 +1,23 @@
> +--source include/not_embedded.inc
> +--source include/have_compress.inc
> +
> +CREATE DATABASE db1;
> +
> +CREATE TABLE db1.t1(a INT);
> +replace_column 1 #;
> +BACKUP DATABASE db1 TO 'db1.bak.gz' WITH COMPRESSION;
> +
> +CREATE TABLE db1.t2(a INT);
> +replace_column 1 #;
> +BACKUP DATABASE db1 TO 'db2.bak.gz' WITH COMPRESSION
> +COMPRESSION_ALGORITHM=gzip;
> +
> +replace_column 1 #;
> +RESTORE FROM 'db1.bak.gz';
> +SHOW TABLES FROM db1;
> +
> +RESTORE FROM 'db2.bak.gz';
> +SHOW TABLES FROM db1;
> +
> +DROP DATABASE db1;
> +--remove_file $MYSQLTEST_VARDIR/master-data/db1.bak.gz
> +--remove_file $MYSQLTEST_VARDIR/master-data/db2.bak.gz
There are errors in this test. You're missing a replace_column call on the
last restore. Please fix and replace result file before commit.
