List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:June 23 2008 4:01pm
Subject:RE: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749, Bug#36778, Bug#36782
View as plain text  
Rafal,

Ok, will do. What about tests for BUG#36778 and BUG#36782 which are rolled
up in this one? Can you tick the boxes on all three bug reports please?

Chuck 

> Thanks for taking into account my comments so far. I still 
> have one final remark. You made the internal type 
> Image_info::Tables public (probably I used this type in my 
> earlier suggestions). But actually doing this is not necessary. 
> Class Image_info::Tables implements public interface 
> backup::Table_list and it is enough to use the public 
> interface (see below).
> 
> After fixing this the patch is good to push.

Thread
bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749,Bug#36778, Bug#36782Chuck Bell20 Jun
  • Re: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749,Bug#36778, Bug#36782Rafal Somla23 Jun
    • RE: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749, Bug#36778, Bug#36782Chuck Bell23 Jun
    • RE: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749, Bug#36778, Bug#36782Chuck Bell23 Jun
      • Re: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618) Bug#36749,Bug#36778, Bug#36782Rafal Somla24 Jun
  • Re: bzr commit into mysql-6.0-backup-myisam branch (cbell:2618)Bug#36749, Bug#36778, Bug#36782Jørgen Løland23 Jun