RE: bzr commit into mysql-6.0-backup branch (cbell:2618) Bug#36749

[Chuck Bell]

Hi, 

> >  2618 Chuck Bell	2008-06-17
> >       BUG#36749 Data Loss after Restore, if Trigger fired 
> on the table that is being Restored.
> >       
> >       The MyISAM native driver is not locking its tables. 
> This results in data losson restore
> >       as either a collision or an overwrite condition occurs.
> >       
> >       This patch corrects the problem by taking an 
> exclusive name lock on all tables prior to
> >       restore of the data (after the metadata step).
> 
> So how is that an "online" backup if you take exclusive 
> metadata locks?
> 
> Or it's accepted that restore can be "offline"?

Restore is indeed blocking and therefore "offline."

> > +/*
> > +  Gets name locks on table list.
> > +*/
> > +int get_name_locks(THD *thd, TABLE_LIST *tables, bool exclusive);
> 
> What is this "exclusive" for?

If true, it calls lock_table_names_exclusively().
If false, it calles lock_table_names().

Chuck