John,
thanks for splitting up the tests into separate ones.
On Mi, 2008-06-18 at 14:14 +0000, John H. Embretsen wrote:
[cut]
> === added file 'mysql-test/suite/falcon/t/falcon_bug_33397.test'
> --- a/mysql-test/suite/falcon/t/falcon_bug_33397.test 1970-01-01 00:00:00 +0000
> +++ b/mysql-test/suite/falcon/t/falcon_bug_33397.test 2008-06-18 14:14:29 +0000
> @@ -0,0 +1,29 @@
> +#
It looks like you are missing the line
--source include/have_falcon.inc
in your new test cases. Please double check.
> +# Bug #33397: ALTER TABLE into non-existing Falcon tablespace causes vague error
> +#
> +
> +--echo *** Bug 33397 ***
> +
> +# ----------------------------------------------------- #
> +# --- Initialisation --- #
> +# ----------------------------------------------------- #
> +let $engine = 'Falcon';
> +eval SET @@storage_engine = $engine;
> +
> +--disable_warnings
> +DROP TABLE IF EXISTS t1;
> +--enable_warnings
> +
> +CREATE TABLE t1(a INT);
> +
> +# ----------------------------------------------------- #
> +# --- Test --- #
> +# ----------------------------------------------------- #
> +
> +--error ER_NO_SUCH_TABLESPACE
> +ALTER TABLE t1 TABLESPACE nosuchtablespace;
> +
> +# ----------------------------------------------------- #
> +# --- Final cleanup --- #
> +# ----------------------------------------------------- #
> +DROP TABLE t1;
Rest looks fine, ok to push.
Best regards,
Hakan
--
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160
98953296
Sun Microsystems GmbH Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering HRB MUC 161028 49.011, 8.376