Re: bzr commit into mysql-6.0-backup branch (oystein.grovlen:2638) Bug#36586

[Øystein Grøvlen]

Sergey,
Thanks for the review.
I will make sure to update my patch according to you comments.
Some comments in-line.


Sergey Vojtovich wrote:

>>       BUG#36586 Online backup stream library can miss end of a stream.
>>       Make sure end-of-stream is detected.
> Could you please extend this comment with user visible effect of this
> problem? E.g.: It was impossible to restore (X) backup image because of
> (Y).

I will make a note saying that restore will hang before this fix.

...

>> +--echo Clean-up
>> +DROP DATABASE mysqltest;
> You forgot to remove 'test.ba' here:
> --remove_file $MYSQLTEST_VARDIR/master-data/test.ba

I thought there was some automatic clean-up. I will add this. But does 
that mean that if the test fails I will not be able to inspect the 
image?  It also seems a bit inconsistent to not require the path when 
creating the file, but require path when deleting it.

...

> It seems to be common for backup not to handle situation when as_read()
> returns BSTREAM_ERROR. But anyway please check with Chuck if it should
> be fixed here within the scope of this patch.

I would really prefer to do this as a separate patch since I have 
another fix waiting for this to be completed.  I will ask Chuck if I 
should make a new bug report for this.

--
Øystein