List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:June 11 2008 8:43pm
Subject:RE: bk commit into 6.0 tree (istruewing:1.2623)
View as plain text  
Hi Ingo, 

> > I get timeout errors on the backup_commit_blocker test on Windows. 

Wouldn't you know it...I tested this again and I can't make it fail.
Nevermind... :|

> > Please specify WL#4259 in the patch comments. It would be easier to 
> > track it there were.
> 
> I would prefer a number that is related to backup testing. 
> The conversion is not part of the implementation of DEBUG_SYNC.

Ok, well maybe we need a new WL or even a bug report.

> In my sync point philosophy, the sync point name reflects its 
...
> I am also open for suggestion, how to rename the sync points 
> so that their position in the code becomes more clear. But I 
> politely refuse to rename the sync points after their 
> function in a specific test. If you still want to have that, 
> please take over.

I will wait and see what Rafal says. I think he has some ideas along this
line.

All other issues/responses were acceptable.

Chuck

Thread
bk commit into 6.0 tree (istruewing:1.2623)Ingo Struewing6 Jun
  • RE: bk commit into 6.0 tree (istruewing:1.2623)Chuck Bell9 Jun
    • Re: bk commit into 6.0 tree (istruewing:1.2623)Ingo Strüwing11 Jun
      • RE: bk commit into 6.0 tree (istruewing:1.2623)Chuck Bell11 Jun
      • RE: bk commit into 6.0 tree (istruewing:1.2623)Chuck Bell12 Jun
        • Re: bk commit into 6.0 tree (istruewing:1.2623)Ingo Strüwing13 Jun
  • Re: bk commit into 6.0 tree (istruewing:1.2623)Rafal Somla12 Jun