Re: bzr commit into mysql-6.0-semi-sync-1.0 tree (hezx:2635) WL#4398

[He Zhenxing]

On 2008-06-09 Mon 10:02 +0200, Mats Kindahl wrote:
> Thank you Serg!
> 
> OK, Jason, then we need to create a new "global" file that is entirely
> focused on the SDK.
> 

Yes, I think this is better.

> Best wishes,
> Mats Kindahl
> 
> Sergei Golubchik wrote:
> > Hi!
> > 
> > On Jun 09, Mats Kindahl wrote:
> >> He Zhenxing wrote:
> >>> Hi Mats
> >>>
> >>> Did you noticed that I included <my_global.h> in plugin.h? 
> >>>
> >>> The functions I added in plugin.h used some typedefs defined in it,
> >>> such as uint32, uchar. I am not quite sure other stuffs defined in
> >>> my_global.h should be exported or not.
> >> No, actually I didn't. I'm reluctant to include my_global.h since it
> >> contain a lot of dependencies on other code in the server... wait...
> >>
> >> ... no, I don't think it is a fundamental problem to include the file.
> >> There are a lot of definitions that are not really needed, but I see
> >> no harm in including it from plugin.h, we just have to make sure that
> >> it is part of the SDK as well.
> > 
> > No, please, don't inclue my_global.h in plugin.h, my_global.h is
> > internal, we are changing it freely and want to continue doing that.
> > plugin.h will be VERY soon strictly monitored to make it difficult for
> > anybody to modify it, the less files are public the better.
> > Besides, my_global.h is and always was written as internal - meaning
> > nobody tried to avoid namespace conflicts when it's used with other
> > projects' headers, nobody tried to minimize the dependencies, or
> > definitions/declarations in it, etc. It cannot be made a part of the
> > public API as is.
> > 
> > And it'd be best if your plugin would not need it, if at all possible.
> > (for all plugins I've helped to create it's true, they don't need
> > internal headers)
> >  
> > Regards / Mit vielen Grüssen,
> > Sergei
> > 
> 
> 
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1