Re: commit into mysql-6.0-falcon:mysql-6.0-falcon branch (olav:2692)

[Olav Sandstaa]

Hakan Kuecuekyilmaz wrote:
> On Do, 2008-06-05 at 13:41 +0000, Olav Sandstaa wrote:#At
> bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-falcon/
>>
>> === modified file 'storage/falcon/SymbolManager.cpp'
>> --- a/storage/falcon/SymbolManager.cpp	2007-09-20 15:44:25 +0000
>> +++ b/storage/falcon/SymbolManager.cpp	2008-06-05 13:41:27 +0000
>> @@ -124,7 +124,7 @@
>>  
>>  	sync.unlock();
>>  	sync.lock (Exclusive);
>> -	symbol = (Symbol*) ((IPTR)(next + 3) & ~3);
>> +	symbol = (Symbol*) (ROUNDUP(((IPTR)(next)), sizeof(void*)));// adr alignment
>>  	IPTR length = p - string;
>>     
>
> Olav, please check our Falcon coding style regarding comments at:
>
>
> http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines#C.2B.2B_Coding_Guidelines_of_Falcon_storage_engine
>
> The coding style is not covered in full, but I think that almost all
> comments are above the code line in question.
>   

Hakan, thanks for the comment. Thanks for pointing to the Falcon coding 
style. I was not able to find anything in it about where to place 
comments. But I agree with you that it is better to place the comment 
above the code line in question. The main reason for me to put it at the 
end of the line was to make it become as "invisible as possible". Since 
this file did not have a single comments from before placing two new 
comments on  separate lines makes this part of the code stand out and 
look like it is an important part of the implementation. Feel free to 
let me know if it would be better to not include the comments at all.

I will commit a new version of the patch where the comments are placed 
on separate lines. Feel free to provide further comments.

Thanks,
Olav