Mats,
> Hi Andrei,
>
> I see no remaining problems that you have not accepted to fix. Once you
> have a new patch, I can approve it.
>
there is no rush :-)
>>>> + if (cur_len + slen + 4 > FN_REFLEN)
>>>> + {
>>>> + /*
>>>> + break the loop whenever remained space could not fit
>>>> + ellipses on the next cycle
>>>> + */
>>>> + my_sprintf(buff + cur_len, (buff + cur_len, "..."));
>>> Show master info is not only for providing human-readable output, it is
>>> also used by applications to get information. You need to ensure that
>>> *all* information is printed *and* that it is printed in a format that
>>> an application can use (it seems like you're using a space-separated
>>> list here).
>>>
>>
>> Please consider two things.
>>
>> 1. it will never happen in the real world that the length of the
>> ignored sever list exceed FN_REFLEN/11 > 46 elements.
>>
>> 2. The point why I made ellipses is because conceptually we would need to
>> report something instead of nothing if an accident happened (not in
>> the real world).
>>
>> An application needs to take care of ellipsis, and I don't see any
>> problem in that. I am not adding ellipesis to an existing parameter's
>> format, it's a new parameter.
>> I hope you share my opinion that we need merely document that (without
>> refering to the real word time time :-).
>
> OK. I would prefer some clearer way of seeing that the information is
> partial, but this will do.
A clearer way should be I_S.show_slave_status.
>
> [snip]
>
>>>> + s_id= uint4korr(buf + SERVER_ID_OFFSET);
>>>> + if ((s_id == ::server_id &&
> !mi->rli.replicate_same_server_id) ||
>>>> + /*
>>>> + the following conjunction deals with IGNORE_SERVER_IDS, if set
>>>> + */
>>>> + (mi->ignore_server_ids.elements > 0 &&
>>>> + mi->repl_server_id_ignore_p(s_id) &&
>>>> + /* everything is filtered out from non-master */
>>>> + (s_id != mi->master_id ||
>>> OK, but could you write out the comments. It was not immediate that the
>>> code was correct.
>>
>> What do you mean "It was not immediate the code is not correct"?
>> How comments can prevent that?
>> And there are comments.
>>
>>> (I.e., that if the master is on the ignore list, all
>>> events are ignored except those relating to the relay log management.)
>>>
>>
>> Sorry, I seem to misunderstand your concern...
>>
>> In the immediate ignored master case the slave needs meta info.
>> Do you really think I need to prove that?
>
> No, but explain that it is the case. Just say "The following conjunction
> deals with IGNORE_SERVER_IDS, if set. If the master is on the ignore
> list, we still need to execute format description log events and rotate
> events."
I'll expand my short comments.
cheers,
Andrei
