List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:June 4 2008 1:17am
Subject:Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)
Bug#24509, WL#3049
View as plain text  
Hi Vlad,

Vladislav Vaintroub wrote:
> #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-wtf/
> 
>  2653 Vladislav Vaintroub	2008-06-04
>       Bug#24509 - 2048 file descriptor limit on windows needs increasing, also 
>       WL#3049 - improved Windows I/O
>       
>       The patch replaces the use of the POSIX I/O interfaces in mysys on Windows with
> 
>       the Win32 API calls (CreateFile, WriteFile, etc).

Wouldn't this be a good opportunity to start to untangle the ifdefery
mess in mysys? We could start splitting the implementations into
different directories, for example:

mysys/win32/file_io.c
mysys/unix/file_io.c
mysys/netware/file_io.c

And each one would implement it's own specified version of my_foo.

Regards,

-- Davi
Thread
commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653) Bug#24509,WL#3049Vladislav Vaintroub4 Jun
  • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Davi Arnaut4 Jun
    • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch(vvaintroub:2653) Bug#24509, WL#3049Konstantin Osipov4 Jun
    • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Joerg Bruehe4 Jun
      • RE: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653) Bug#24509, WL#3049Vladislav Vaintroub4 Jun
        • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Davi Arnaut4 Jun
          • RE: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653) Bug#24509, WL#3049Vladislav Vaintroub4 Jun
            • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Davi Arnaut4 Jun
        • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Joerg Bruehe4 Jun
          • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049 [ifdefery]Davi Arnaut5 Jun
      • Re: commit into mysql-6.0-wtf:mysql-6.0-wtf branch (vvaintroub:2653)Bug#24509, WL#3049Davi Arnaut4 Jun