List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:May 28 2008 7:24am
Subject:Re: commit into mysql-6.0 branch (dlenev:2651) WL#3726
View as plain text  
* Dmitry Lenev <dlenev@stripped> [08/05/28 09:23]:
> @@ -4284,19 +4284,13 @@

Could you please add diff -p to your bazaar.conf?

kostja@bodhi:~$ cat .bazaar/bazaar.conf 
[DEFAULT]
email = Konstantin Osipov <konstantin@stripped>
per_file_commits= on 
viz-compact-view = yes
allow_remote_options = mysql
[ALIASES]
diff=diff --diff-options=-p
vimdiff=diff --using=vimdiff
revert=revert --no-backup

> +          TABLE_LIST *save_next_global= table->next_global;
> +          table->next_global= 0;
> +          /*
> +            QQ: It is a tad inefficient to use this function here...
> +                May be we should simply introduce TDC API function
> +                which will destroy all unused TABLE instances for
> +                particular share ?
> +          */
> +          close_cached_tables(thd, table, FALSE, FALSE);
> +          table->next_global= save_next_global;

No, we should be fine to use one hammer for all nails in this
case, simplicity is more important.

The patch is OK to push.

-- 
Thread
commit into mysql-6.0 branch (dlenev:2651) WL#3726Dmitry Lenev28 May
  • Re: commit into mysql-6.0 branch (dlenev:2651) WL#3726Konstantin Osipov28 May