Re: bk commit into 6.0 tree (davi:1.2645) BUG#36785

[Marc Alff]

Hi Davi,

OK to push.

Regards,
Marc.


Davi Arnaut wrote:
> Below is the list of changes that have just been committed into a local
> 6.0 repository of davi.  When davi does a push these changes
> will be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2008-05-19 19:39:24-03:00, davi@stripped +8 -0
>   Bug#36785: Wrong error message when group_concat() exceeds max length
>   
>   The problem is that when ER_CUT_VALUE_GROUP_CONCAT is elevated
>   to a error, message does not get updated with the number of cut
>   lines when group_concat() exceeds max length.
>   
>   The solution is to modify the warning message to be more meaningful
>   by giving the number of the line that was cut and to issue the warning
>   for each line that is cut. This approach is inline with how other
>   per-row truncated data warnings are issued avoids violating the warning
>   internal interface.
>
>   
Good.

(...)
> diff -Nrup a/sql/sql_error.h b/sql/sql_error.h
> --- a/sql/sql_error.h	2007-06-07 05:39:32 -03:00
> +++ b/sql/sql_error.h	2008-05-19 19:39:16 -03:00
> @@ -30,6 +30,8 @@ public:
>      if (msg_arg)
>        set_msg(thd, msg_arg);
>    }
> +
> +private:
>   
Excellent.

Don't bother removing it completely, it's done already :)


>    void set_msg(THD *thd, const char *msg_arg);
>  };
>  
>
>