bk commit into 4.1 tree (knielsen:1.2503)

[knielsen]

Below is the list of changes that have just been committed into a local
4.1 repository of knielsen. When knielsen does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2503 06/04/08 22:27:43 knielsen@stripped +1 -0
  $MYSQL_TEST was broken with --valgrind.

  mysql-test/mysql-test-run.pl
    1.62 06/04/08 22:27:27 knielsen@stripped +11 -5
    $MYSQL_TEST was broken with --valgrind.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	knielsen
# Host:	rt.int.sifira.dk
# Root:	/usr/local/mysql/mysql-4.1-vgfix

--- 1.61/mysql-test/mysql-test-run.pl	2006-04-07 13:34:35 +02:00
+++ 1.62/mysql-test/mysql-test-run.pl	2006-04-08 22:27:27 +02:00
@@ -2316,11 +2316,6 @@
 
   mtr_init_args(\$args);
 
-  if ( defined $opt_valgrind_mysqltest )
-  {
-    valgrind_arguments($args, \$exe);
-  }
-
   mtr_add_arg($args, "--no-defaults");
   mtr_add_arg($args, "--socket=%s", $master->[0]->{'path_mysock'});
   mtr_add_arg($args, "--database=test");
@@ -2397,6 +2392,17 @@
   # ----------------------------------------------------------------------
   # Add arguments that should not go into the MYSQL_TEST env var
   # ----------------------------------------------------------------------
+
+  if ( defined $opt_valgrind_mysqltest )
+  {
+    # Prefix the Valgrind options to the argument list.
+    # We do this here, since we do not want to Valgrind the nested invocations
+    # of mysqltest; that would mess up the stderr output causing test failure.
+    my @args_saved = @$args;
+    mtr_init_args(\$args);
+    valgrind_arguments($args, \$exe);
+    mtr_add_arg($args, "%s", $_) for @args_saved;
+  }
 
   mtr_add_arg($args, "-R");
   mtr_add_arg($args, $tinfo->{'result_file'});