Re: bk commit into 5.0 tree (cmiller:1.2624) BUG#36570

[Davi Arnaut]

Hi Chad,

Patch approved, a couple of minor comment below.

Chad MILLER wrote:
> ChangeSet@stripped, 2008-05-13 08:37:27-04:00, cmiller@stripped +6 -0
>   Bug#36570: Parse error of CREATE PROCEDURE stmt with comments on \
>   	slave
>   
>   The stored-routine code took the contents of the (lowest) parser

"(lowest) parser"? I guess you mean that it took the contents of the
user supplied string.

>   and copied it directly to the binlog, which causes problems if there
>   is a special case of interpretation at the parser level -- which 
>   there is, in the "/*!VER */" comments.  The trailing "*/" caused
>   errors on the slave, naturally.

[..]

> diff -Nrup a/mysql-test/t/rpl_sp.test b/mysql-test/t/rpl_sp.test
> --- a/mysql-test/t/rpl_sp.test	2008-01-31 06:17:25 -05:00
> +++ b/mysql-test/t/rpl_sp.test	2008-05-13 08:37:24 -04:00
> @@ -32,7 +32,7 @@ delimiter |;
>  # deterministic and updating data, while it's not ok to create such a
>  # function. We test this.
>  
> -create procedure foo()
> +/*!50001 create procedure foo() */
>  begin
>    declare b int;
>    set b = 8;
> @@ -186,7 +186,7 @@ begin
>         insert into t1 values (x);
>         return x+2;
>  end|
> -create function fn1(x int)
> +/*!50001 create function fn1(x int) */
>         returns int
>         deterministic
>  begin

Please don't modify other test cases, add one specifically for this bug.
Also add test case for sp names like ` name`, `name`()`label` and variants.

Regards,

-- 
Davi Arnaut, Software Engineer
MySQL Server Runtime Team
Database Group, Sun Microsystems