bk commit into 6.0 tree (istruewing:1.2617) WL#866

[Ingo Struewing]

Below is the list of changes that have just been committed into a local
6.0 repository of istruewing.  When istruewing does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-05-09 20:08:36+02:00, istruewing@stripped +3 -0
  WL#866 - Online backup driver for MyISAM.
  
  Additional fix ups.

  sql/backup/backup_aux.h@stripped, 2008-05-09 20:08:34+02:00, istruewing@stripped +1 -1
    unneeded initialization

  sql/backup/be_thread.cc@stripped, 2008-05-09 20:08:34+02:00, istruewing@stripped +0 -3
    no need to "delete" if thd is NULL. C++ cast.

  sql/backup/stream_v1_transport.c@stripped, 2008-05-09 20:08:34+02:00,
istruewing@stripped +1 -1
    Prevent a sign extension when an unsigned char is casted to an
    unsigned long for a shift operation.

diff -Nrup a/sql/backup/backup_aux.h b/sql/backup/backup_aux.h
--- a/sql/backup/backup_aux.h	2008-03-05 18:48:04 +01:00
+++ b/sql/backup/backup_aux.h	2008-05-09 20:08:34 +02:00
@@ -116,7 +116,7 @@ inline int free_table_list(TABLE_LIST *a
   if (all_tables)
   {
     TABLE_LIST *tbl= all_tables;
-    TABLE_LIST *prev= tbl;
+    TABLE_LIST *prev;
     while (tbl != NULL)
     {
       prev= tbl;
diff -Nrup a/sql/backup/be_thread.cc b/sql/backup/be_thread.cc
--- a/sql/backup/be_thread.cc	2008-03-04 17:08:40 +01:00
+++ b/sql/backup/be_thread.cc	2008-05-09 20:08:34 +02:00
@@ -48,10 +48,7 @@ THD *create_new_thd()
 
   thd= new THD;
   if (unlikely(!thd))
-  {
-    delete thd;
     DBUG_RETURN(0);
-  }
   THD_CHECK_SENTRY(thd);
 
   thd->thread_stack = (char*)&thd; // remember where our stack is  
diff -Nrup a/sql/backup/stream_v1_transport.c b/sql/backup/stream_v1_transport.c
--- a/sql/backup/stream_v1_transport.c	2008-05-09 12:27:19 +02:00
+++ b/sql/backup/stream_v1_transport.c	2008-05-09 20:08:34 +02:00
@@ -696,7 +696,7 @@ int load_buffer(backup_stream *s)
     for (i= 0; i<4; ++i)
     {
       block_size >>= 8;
-      block_size |= (*(s->buf.begin++)) << 3*8;
+      block_size |= ((unsigned long int)*(s->buf.begin++)) << 3*8;
     }
 
     /*