Hi!
On May 06, Chuck Bell wrote:
> Hi Svoj,
>
> > > + example_hton->db_type= DB_TYPE_EXAMPLE_DB;
> > >
> > > DBUG_RETURN(0);
> > > }
> > Let me quote comment from handler.h:
> >
> > <quot>
> > Historical number used for frm file to determine the correct
> > storage engine.
> > This is going away and new engines will just use "name" for this.
> > </quot>
> >
> > So we're using:
> > - obsolete class member, which will be removed some time;
> > - possibly uninitialized class member as a storage engine is
> > not required to
> > initialize it. And example_hton is a great example of that.
> >
> > My proposal was to add new handlerton flag, but Rafal didn't
> > like it. If you really think that flag is not a good idea,
> > please use name instead of db_type.
>
> Ok, but name is not a valid method/attribute in the handlerton class. The
> server code has over 250 references to db_type so it is clear (to me) that
> the switch has yet to occur. Thus, I recommend continue with db_type and
> address the issue when/if db_type is removed.
But then it'll never be removed because "oh, online backup uses it and
we need time to fix it", with "online backup" replaced by "feature X"
for any arbitrary X.
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
