Chuck,
Thanks for fixing the patch. I accept it now but see my remarks below about
redundant header files. If I'm right that they are not needed please remove them
before pushing - no need to review this again.
Rafal
cbell@stripped wrote:
> --- /dev/null Wed Dec 31 16:00:00 196900
> +++ b/sql/backup/be_nodata.cc 2008-04-25 11:31:27 -04:00
> @@ -0,0 +1,132 @@
> +/* Copyright (C) 2004-2007 MySQL AB
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; version 2 of the License.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software
> + Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> +*/
> +
> +/**
> + @file
> +
> + @brief Contains the nodata backup algorithm driver.
> +
> + This file contains the nodata backup algorithm (also called a "driver"
> + in the online backup terminology. The nodata driver does not read or
> + write to any files or tables. It is used to allow the backup and
> + restore of storage engines that do not store data. These include:
> +
> + DB_TYPE_MRG_MYISAM
> + DB_TYPE_BLACKHOLE_DB
> + DB_TYPE_FEDERATED_DB
> + DB_TYPE_EXAMPLE_DB
> +*/
> +#include "../mysql_priv.h"
> +#include "backup_engine.h"
> +#include "be_nodata.h"
> +#include "backup_aux.h"
> +#include "rpl_record.h"
I think rpl_record.h is not needed below. If so please remove it. If it is
necessary, please change it to #include "../rpl_record.h".
> diff -Nrup a/sql/backup/be_nodata.h b/sql/backup/be_nodata.h
> --- /dev/null Wed Dec 31 16:00:00 196900
> +++ b/sql/backup/be_nodata.h 2008-04-25 11:31:28 -04:00
> @@ -0,0 +1,158 @@
> +#ifndef _NODATA_BACKUP_H
> +#define _NODATA_BACKUP_H
> +
> +#include <backup_engine.h>
> +#include <backup/image_info.h> // to define default backup image class
> +#include <backup/buffer_iterator.h>
> +#include <backup/be_thread.h>
The two last header files (buffer_iterator.h and be_thread.h) not needed most
probably.
