Hi Serge,
I can place my backup tests in the seperate suite of backup.Also I will do
the required changes in the code as you mentioned.
Warm Regards,
Hema Sridharan
QA Developer
MySQL Americas Inc, www.mysql.com
Office: Austin TX 78728, USA
Are you MySQL certified? www.mysql.com/certification
> -----Original Message-----
> From: Serge Kozlov [mailto:skozlov@stripped]
> Sent: Wednesday, April 16, 2008 7:12 AM
> To: hema@stripped
> Cc: commits@stripped; Jonathan Miller; 'Lars Thalmann'
> Subject: Re: bk commit into 6.0 tree (hsridharan:1.2608)
>
> Hi, Hema.
>
> See my notes below marked "skozlov". I approve your commit
> with fixes commented below.
>
> Jeb: Hema places backup tests inside main suite. What do you
> think about specail suite called 'backup' and collect there
> all backup tests (and may be mysqldump too)?
>
> hema@stripped wrote:
> > Below is the list of changes that have just been committed into a
> > local 6.0 repository of hsridharan. When hsridharan does a
> push these
> > changes will be propagated to the main repository and,
> within 24 hours
> > after the push, to the public repository.
> > For information on how to access the public repository see
> > http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> >
> > ChangeSet@stripped, 2008-04-11 16:58:31+02:00,
> hsridharan@stripped +2 -0
> > backup_objectspall.test:
> > Test of metadata consistency
> > backup_objectspall.result:
> > Results file for Test of metadata consistency
> >
> > mysql-test/r/backup_objectspall.result@stripped, 2008-04-11
> > 16:58:18+02:00, hsridharan@stripped +229 -0
> > Results file for Test of metadata consistency
> >
> > mysql-test/r/backup_objectspall.result@stripped, 2008-04-11
> > 16:58:18+02:00, hsridharan@stripped +0 -0
> >
> > mysql-test/t/backup_objectspall.test@stripped, 2008-04-11
> 16:57:56+02:00,
> > hsridharan@stripped +179 -0
> > Test of metadata consistency
> >
> > mysql-test/t/backup_objectspall.test@stripped, 2008-04-11
> 16:57:56+02:00,
> > hsridharan@stripped +0 -0
> >
> > diff -Nrup a/mysql-test/r/backup_objectspall.result
> > b/mysql-test/r/backup_objectspall.result
> > --- /dev/null Wed Dec 31 16:00:00 196900
> > +++ b/mysql-test/r/backup_objectspall.result 2008-04-11
> 16:58:18 +02:00
> > @@ -0,0 +1,229 @@
> > +
> > +starting the test for backup
> > +
> > +DROP DATABASE IF EXISTS bup_objectspall; CREATE DATABASE
> > +bup_objectspall; USE bup_objectspall; Creating table CREATE TABLE
> > +country_in(ccode char(10), city varchar(10))engine=innodb; CREATE
> > +TABLE country_my(ccode char(10), city varchar(10))engine=myisam;
> > +CREATE TABLE country_fa(ccode char(10), city
> > +varchar(10))engine=falcon; CREATE TABLE country_me(ccode char(10),
> > +city varchar(10))engine=memory; CREATE TABLE country_ar(ccode
> > +char(10), city varchar(10))engine=archive; loading data
> INSERT INTO
> > +country_in
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','bomb'),(
> > +'US','Washington');
> >
> > +INSERT INTO country_fa
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','bomb'),(
> > +'US','ohio'),('IND','kashmir');
> >
> > +INSERT INTO country_my
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','bomb'),(
> > +'US','seattle');
> >
> > +INSERT INTO country_me
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','bomb'),(
> > +'US','NY'),('IND','calcutta');
> >
> > +INSERT INTO country_ar
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','bomb'),(
> > +'US','virginia'),('IND','hyd');
> >
> > +SELECT * FROM country_in;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US Washington
> > +SELECT * FROM country_my;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US seattle
> > +SELECT * FROM country_fa;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US ohio
> > +IND kashmir
> > +SELECT * FROM country_me;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US NY
> > +IND calcutta
> > +SELECT * FROM country_ar;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US virginia
> > +IND hyd
> > +CREATE PROCEDURE countryinfo_in (IN loc char(3)) BEGIN
> SELECT * FROM
> > +country_in WHERE ccode=loc; END;
> > +||
> > +CREATE PROCEDURE countryinfo_my (IN loc char(3)) BEGIN
> SELECT * FROM
> > +country_my WHERE ccode=loc; END;
> > +||
> > +CREATE PROCEDURE countryinfo_fa (IN loc char(3)) BEGIN
> SELECT * FROM
> > +country_fa WHERE ccode=loc; END;
> > +||
> > +CREATE PROCEDURE countryinfo_me (IN loc char(3)) BEGIN
> SELECT * FROM
> > +country_me WHERE ccode=loc; END;
> > +||
> > +CREATE PROCEDURE countryinfo_ar (IN loc char(3)) BEGIN
> SELECT * FROM
> > +country_ar WHERE ccode=loc; END;
> > +||
> > +CALL countryinfo_in('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US Washington
> > +CALL countryinfo_my('IND');
> > +ccode city
> > +IND chennai
> > +IND bomb
> > +CALL countryinfo_my('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US seattle
> > +CALL countryinfo_fa('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US ohio
> > +CALL countryinfo_me('IND');
> > +ccode city
> > +IND chennai
> > +IND bomb
> > +IND calcutta
> > +CALL countryinfo_ar('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US virginia
> > +showing objects and create statements.
> > +SHOW CREATE PROCEDURE countryinfo_in;;
> > +Procedure countryinfo_in
> > +sql_mode
> > +Create Procedure CREATE DEFINER=`root`@`localhost` PROCEDURE
> > `countryinfo_in`(IN loc char(3))
> > +BEGIN
> > +SELECT * FROM country_in WHERE ccode=loc; END
> > +character_set_client latin1
> > +collation_connection latin1_swedish_ci
> > +Database Collation latin1_swedish_ci
> > +SHOW CREATE PROCEDURE countryinfo_fa;;
> > +Procedure countryinfo_fa
> > +sql_mode
> > +Create Procedure CREATE DEFINER=`root`@`localhost` PROCEDURE
> > `countryinfo_fa`(IN loc char(3))
> > +BEGIN
> > +SELECT * FROM country_fa WHERE ccode=loc; END
> > +character_set_client latin1
> > +collation_connection latin1_swedish_ci
> > +Database Collation latin1_swedish_ci
> > +SHOW CREATE PROCEDURE countryinfo_my;;
> > +Procedure countryinfo_my
> > +sql_mode
> > +Create Procedure CREATE DEFINER=`root`@`localhost` PROCEDURE
> > `countryinfo_my`(IN loc char(3))
> > +BEGIN
> > +SELECT * FROM country_my WHERE ccode=loc; END
> > +character_set_client latin1
> > +collation_connection latin1_swedish_ci
> > +Database Collation latin1_swedish_ci
> > +backup data
> > +BACKUP DATABASE bup_objectspall TO 'bup_objectspall.bak'; backup_id
> > +1
> > +dropping database.
> > +DROP DATABASE bup_objectspall;
> > +RESTORE FROM 'bup_objectspall.bak';
> > +backup_id
> > +2
> > +showing objects and create statements SHOW CREATE DATABASE
> > +bup_objectspall;;
> > +Database bup_objectspall
> > +Create Database CREATE DATABASE `bup_objectspall` /*!40100
> > DEFAULT CHARACTER SET latin1 */
> > +SHOW CREATE PROCEDURE countryinfo_in;;
> > +Procedure countryinfo_in
> > +sql_mode
> > +Create Procedure CREATE DEFINER=`root`@`localhost` PROCEDURE
> > `countryinfo_in`(IN loc char(3))
> > +BEGIN
> > +SELECT * FROM country_in WHERE ccode=loc; END
> > +character_set_client latin1
> > +collation_connection latin1_swedish_ci
> > +Database Collation latin1_swedish_ci
> > +SHOW CREATE PROCEDURE countryinfo_fa;;
> > +Procedure countryinfo_fa
> > +sql_mode
> > +Create Procedure CREATE DEFINER=`root`@`localhost` PROCEDURE
> > `countryinfo_fa`(IN loc char(3))
> > +BEGIN
> > +SELECT * FROM country_fa WHERE ccode=loc; END
> > +character_set_client latin1
> > +collation_connection latin1_swedish_ci
> > +Database Collation latin1_swedish_ci
> > +INSERT INTO country_in VALUES('US','boston'); INSERT INTO
> country_fa
> > +VALUES('IND','jaipur'); INSERT INTO country_my
> VALUES('US','natick');
> > +SELECT * FROM country_in; ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US Washington
> > +US boston
> > +SELECT * FROM country_my;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US seattle
> > +US natick
> > +SELECT * FROM country_fa;
> > +ccode city
> > +IND chennai
> > +US sfo
> > +US austin
> > +IND bomb
> > +US ohio
> > +IND kashmir
> > +IND jaipur
> > +CALL countryinfo_in('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US Washington
> > +US boston
> > +CALL countryinfo_fa('IND');
> > +ccode city
> > +IND chennai
> > +IND bomb
> > +IND kashmir
> > +IND jaipur
> > +CALL countryinfo_my('US');
> > +ccode city
> > +US sfo
> > +US austin
> > +US seattle
> > +US natick
> > +
> > +*** DROP bup_objectspall DATABASE ****
> > +
> > +DROP DATABASE bup_objectspall;
> > diff -Nrup a/mysql-test/t/backup_objectspall.test
> > b/mysql-test/t/backup_objectspall.test
> > --- /dev/null Wed Dec 31 16:00:00 196900
> > +++ b/mysql-test/t/backup_objectspall.test 2008-04-11
> 16:57:56 +02:00
> > @@ -0,0 +1,179 @@
> >
> +#####################################################################
> > +###########
> >
> > +# Author: Hema
> > +# Date: 2008-03-11
> > +# Purpose: To test the metadata consistency by using object stored
> > procedures # for all storage engines.
> >
> +#####################################################################
> > +##########
> >
> > +--source include/have_innodb.inc
> > +--source include/not_embedded.inc
> > +--source include/have_debug.inc
> > +
> > +connect (backup,localhost,root,,);
> > +connect (breakpoints,localhost,root,,);
> > +
> > +##############################################################
> > +--echo
> > +--echo starting the test for backup
> > +--echo
> > +##############################################################
> > +
> > +--error 0,1
> > +--remove_file $MYSQLTEST_VARDIR/master-data/bup_objectspall.bak
>
> Probably you don't need to remove file here because you
> delete it at end of test.
>
>
> > +
> > +#Create Database and object stored procedure for this test.
> > +
> > +--disable_warnings
> > +DROP DATABASE IF EXISTS bup_objectspall;
> > +--enable_warnings
> > +
> > +CREATE DATABASE bup_objectspall;
> > +USE bup_objectspall;
> > +
> > +#Create table with all storage engines and load with data.
> > +
> > +--echo Creating table
>
> Please select text "--echo" by special characters like "*"
> because it is
> easy to analyze a result file.
> --echo *** Creating table ***
>
>
> > +
> > +CREATE TABLE country_in(ccode char(10), city
> varchar(10))engine=innodb;
> > +
> > +CREATE TABLE country_my(ccode char(10), city
> varchar(10))engine=myisam;
> > +
> > +CREATE TABLE country_fa(ccode char(10), city
> varchar(10))engine=falcon;
> > +
> > +CREATE TABLE country_me(ccode char(10), city
> varchar(10))engine=memory;
> > +
> > +CREATE TABLE country_ar(ccode char(10), city
> varchar(10))engine=archive;
> > +
> > +--echo loading data
> > +
> > +INSERT INTO country_in
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','
> bomb'),('US','Washington');
> >
> > +
> > +INSERT INTO country_fa
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','
> bomb'),('US','ohio'),('IND','kashmir');
> >
> > +
> > +INSERT INTO country_my
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','
> bomb'),('US','seattle');
> >
> > +
> > +INSERT INTO country_me
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','
> bomb'),('US','NY'),('IND','calcutta');
> >
> > +
> > +INSERT INTO country_ar
> >
> +VALUES('IND','chennai'),('US','sfo'),('US','austin'),('IND','
> bomb'),('US','virginia'),('IND','hyd');
> >
> > +
> > +SELECT * FROM country_in;
> > +
> > +SELECT * FROM country_my;
> > +
> > +SELECT * FROM country_fa;
> > +
> > +SELECT * FROM country_me;
> > +
> > +SELECT * FROM country_ar;
>
> Please add ORDER BY clause for all SELECT statements.
>
> > +
> > +#Create stored procedures for the table
> > +
> > +delimiter ||;
> > +CREATE PROCEDURE countryinfo_in (IN loc char(3))
> > +BEGIN
> > + SELECT * FROM country_in WHERE ccode=loc;
> > +END;
> > +||
> > +
> > +CREATE PROCEDURE countryinfo_my (IN loc char(3))
> > +BEGIN
> > + SELECT * FROM country_my WHERE ccode=loc;
> > +END;
> > +||
> > +
> > +CREATE PROCEDURE countryinfo_fa (IN loc char(3))
> > +BEGIN
> > + SELECT * FROM country_fa WHERE ccode=loc;
> > +END;
> > +||
> > +
> > +CREATE PROCEDURE countryinfo_me (IN loc char(3))
> > +BEGIN
> > + SELECT * FROM country_me WHERE ccode=loc;
> > +END;
> > +||
> > +
> > +CREATE PROCEDURE countryinfo_ar (IN loc char(3))
> > +BEGIN
> > + SELECT * FROM country_ar WHERE ccode=loc;
> > +END;
> > +||
> > +
> > +delimiter ;||
> > +
> > +#Excercise the objects
> > +
> > +CALL countryinfo_in('US');
> > +
> > +CALL countryinfo_my('IND');
> > +
> > +CALL countryinfo_my('US');
> > +
> > +CALL countryinfo_fa('US');
> > +
> > +CALL countryinfo_me('IND');
> > +
> > +CALL countryinfo_ar('US');
> > +
> > +#Show the data and Create statements
> > +
> > +--echo showing objects and create statements.
> > +
> > +--query_vertical SHOW CREATE PROCEDURE countryinfo_in;
> > +--query_vertical SHOW CREATE PROCEDURE countryinfo_fa;
> > +--query_vertical SHOW CREATE PROCEDURE countryinfo_my;
> > +
> > +#Backup and restore data.
> > +--echo backup data
> > +
> > +BACKUP DATABASE bup_objectspall TO 'bup_objectspall.bak';
> > +
> > +--echo dropping database.
> > +DROP DATABASE bup_objectspall;
> > +
> > +#RESTORE FROM bup_objectspall.bak;
> > +
> > +RESTORE FROM 'bup_objectspall.bak';
> > +
> > +#show data and create statements
> > +--echo showing objects and create statements
> > +--query_vertical SHOW CREATE DATABASE bup_objectspall;
> > +--query_vertical SHOW CREATE PROCEDURE countryinfo_in;
> > +--query_vertical SHOW CREATE PROCEDURE countryinfo_fa;
> > +
> > +#Excercise the objects after restore to make sure if objects are
> > backedup and re# stored properly.
> > +
> > +INSERT INTO country_in VALUES('US','boston');
> > +
> > +INSERT INTO country_fa VALUES('IND','jaipur');
> > +
> > +INSERT INTO country_my VALUES('US','natick');
> > +
> > +SELECT * FROM country_in;
> > +
> > +SELECT * FROM country_my;
> > +
> > +SELECT * FROM country_fa;
> > +
> > +CALL countryinfo_in('US');
> > +
> > +CALL countryinfo_fa('IND');
> > +
> > +CALL countryinfo_my('US');
> > +
> > +# Test cleanup section
> > +
> > +--echo
> > +--echo *** DROP bup_objectspall DATABASE ****
> > +--echo
> > +
> > +DROP DATABASE bup_objectspall;
> > +
> > +--remove_file $MYSQLTEST_VARDIR/master-data/bup_objectspall.bak
> > +
> > +
> > +
> > +
> >
> > --
> > MySQL Code Commits Mailing List
> > For list archives: http://lists.mysql.com/commits
> > To unsubscribe:
> http://lists.mysql.com/commits?unsub=1
> >
>
>
> --
> Serge Kozlov, QA Developer
> MySQL AB, Moscow, Russia, www.mysql.com
> Office:
>
> Are you MySQL certified? www.mysql.com/certification
>
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe: http://lists.mysql.com/commits?unsub=1
>
>
