List:Commits« Previous MessageNext Message »
From:cpowers Date:April 9 2008 8:49pm
Subject:bk commit into 6.0 tree (cpowers:1.2636) BUG#35692
View as plain text  
Below is the list of changes that have just been committed into a local
6.0 repository of cpowers.  When cpowers does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-04-09 15:49:00-05:00, cpowers@stripped +1 -0
  Bug#35692, "Running falcon_record_cache_memory_leak2-big.test crashes Falcon"
  
  Table::validateUpdate() -- reverse lock order of syncPrior and RecordLeaf::syncObject.

  storage/falcon/Table.cpp@stripped, 2008-04-09 15:48:57-05:00, cpowers@stripped +3 -3
    Reversed lock order of syncPrior and RecordLeaf::syncObject by doing tree fetch first.

diff -Nrup a/storage/falcon/Table.cpp b/storage/falcon/Table.cpp
--- a/storage/falcon/Table.cpp	2008-04-09 14:49:16 -05:00
+++ b/storage/falcon/Table.cpp	2008-04-09 15:48:57 -05:00
@@ -3650,11 +3650,11 @@ bool Table::validateUpdate(int32 recordN
 	if (deleting)
 		return false;
 
-	Sync syncPrior(getSyncPrior(recordNumber), "Table::validateUpdate");
-	syncPrior.lock(Shared);
-	
 	Record *record = treeFetch(recordNumber);
 	Record *initial = record;
+	
+	Sync syncPrior(getSyncPrior(recordNumber), "Table::validateUpdate");
+	syncPrior.lock(Shared);
 	
 	while (record)
 		{
Thread
bk commit into 6.0 tree (cpowers:1.2636) BUG#35692cpowers9 Apr