bk commit into 6.0 tree (klewis:1.2634) BUG#35692

[klewis]

Below is the list of changes that have just been committed into a local
6.0 repository of klewis.  When klewis does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-04-09 11:21:20-05:00, klewis@klewis-mysql. +1 -0
  Bug#35692 - Don't use a pointer to a Sync object since it will 
  not get released when it goes out of scope.

  storage/falcon/Table.cpp@stripped, 2008-04-09 11:21:10-05:00, klewis@klewis-mysql. +4 -7
    Bug#35692 - Don't use a pointer to a Sync object since it will 
    not get released when it goes out of scope.

diff -Nrup a/storage/falcon/Table.cpp b/storage/falcon/Table.cpp
--- a/storage/falcon/Table.cpp	2008-04-09 09:51:58 -05:00
+++ b/storage/falcon/Table.cpp	2008-04-09 11:21:10 -05:00
@@ -963,15 +963,12 @@ Record* Table::backlogFetch(int32 record
 
 Record* Table::rollbackRecord(RecordVersion * recordToRollback, Transaction *transaction)
 {
-	Sync * syncPrior = NULL;
+	Sync syncPrior(getSyncPrior(recordToRollback), "Table::rollbackRecord");
 	
-	 //cwp tbd: Problem if systemConnection->rollback() and table deleted
+	//cwp tbd: Problem if systemConnection->rollback() and table deleted
 	if (!transaction->systemTransaction)
-		{
-		syncPrior = NEW Sync(getSyncPrior(recordToRollback), "Table::rollbackRecord");
-		syncPrior->lock(Shared);
-		}
-	
+		syncPrior.lock(Shared);
+
 #ifdef CHECK_RECORD_ACTIVITY
 	recordToRollback->active = false;
 #endif