bk commit into 6.0 tree (vvaintroub:1.2628)

[vvaintroub]

Below is the list of changes that have just been committed into a local
6.0 repository of vvaintroub.  When vvaintroub does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-04-07 16:40:24+02:00, vvaintroub@wva. +2 -0
  - Fix GCC warning
  - Make release  build debuggable

  CMakeLists.txt@stripped, 2008-04-07 16:40:21+02:00, vvaintroub@wva. +3 -2
    Add /debug to linker flags when producing PDB in release mode

  storage/falcon/StorageHandler.cpp@stripped, 2008-04-07 16:40:22+02:00, vvaintroub@wva. +4 -4
    Fix GCC warning (char used as array index, GCC wants 'signed' or 'unsigned').

diff -Nrup a/CMakeLists.txt b/CMakeLists.txt
--- a/CMakeLists.txt	2008-04-06 01:20:24 +02:00
+++ b/CMakeLists.txt	2008-04-07 16:40:21 +02:00
@@ -117,8 +117,9 @@ SET(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLA
 SET(CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO} -DDBUG_OFF")
 
 # enable debug info also in Release build, to be able to analyze crashes
-SET(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -Zi")
-SET(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -Zi")
+SET(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /Zi")
+SET(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} /Zi")
+SET(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /debug") 
 
 # VS2003 needs the /Op compiler option to disable floating point optimizations
 IF(CMAKE_GENERATOR MATCHES "Visual Studio 7")
diff -Nrup a/storage/falcon/StorageHandler.cpp b/storage/falcon/StorageHandler.cpp
--- a/storage/falcon/StorageHandler.cpp	2008-04-06 00:09:14 +02:00
+++ b/storage/falcon/StorageHandler.cpp	2008-04-07 16:40:22 +02:00
@@ -94,11 +94,11 @@ int init()
 {
 	const char *p;
 	
-	for (p = WHITE_SPACE; *p;)
-		charTable[*p++] = 1;
+	for (p = WHITE_SPACE; *p; p++)
+		charTable[(unsigned char)*p] = 1;
 	
-	for (p = PUNCTUATION_CHARS; *p;)
-		charTable[*p++] = 1;
+	for (p = PUNCTUATION_CHARS; *p; p++)
+		charTable[(unsigned char)*p] = 1;
 	
 	return 1;
 }