List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:April 7 2008 10:05am
Subject:Re: bk commit into 6.0 tree (dlenev:1.2620) BUG#35733
View as plain text  
* dlenev@stripped <dlenev@stripped> [08/04/07 11:56]:
> ChangeSet@stripped, 2008-04-07 11:53:00+04:00, dlenev@stripped +1 -0
>   Tentative fix for bug #35733 "main.symlink.test fails".
>   
>   The problem was that symlink.test failed due to debug assertions
>   or due to errors emitted for wrong statements (in non-debug builds)
>   if server was run with --thread-handling=pool-of-threads option.

OK to push.

>     QQ: Is HA_ERR_TABLE_EXIST a right error code ?

I think nothing else matches better, and we're introducing a
precedent anyway.

> diff -Nrup a/storage/myisam/mi_create.c b/storage/myisam/mi_create.c
> --- a/storage/myisam/mi_create.c	2007-10-09 21:55:16 +04:00
> +++ b/storage/myisam/mi_create.c	2008-04-07 11:52:56 +04:00
> @@ -634,6 +634,7 @@ int mi_create(const char *name,uint keys
>      my_printf_error(0, "MyISAM table '%s' is in use "
>                      "(most likely by a MERGE table). Try FLUSH TABLES.",
>                      MYF(0), name + dirname_length(name));
> +    my_errno= HA_ERR_TABLE_EXIST;
>      goto err;
>    }

-- 
Konstantin Osipov                    Moscow, Russia
MySQL Server Runtime Team Lead       Database Group, Sun Microsystems
Thread
bk commit into 6.0 tree (dlenev:1.2620) BUG#35733dlenev7 Apr
  • Re: bk commit into 6.0 tree (dlenev:1.2620) BUG#35733Konstantin Osipov7 Apr