List:Commits« Previous MessageNext Message »
From:Tatjana A Nuernberg Date:April 7 2008 3:10am
Subject:bk commit into 4.1 tree (tnurnberg:1.2714) BUG#35616
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of tnurnberg. When tnurnberg does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-04-07 05:10:20+02:00, tnurnberg@stripped +1 -0
  Bug#35616: memory overrun on 64-bit linux on setting large values for keybuffer-size
  
  We could allocate chunks larger than 4GB, but did our size-accounting in 32-bit
  values. This could lead to spurious warnings, inaccurate accounting, and, in
  theory, data loss.
  
  Affected: 64-bit platforms. At least one buffer larger than 4GB. For potential
  data loss, a re-alloc on such a buffer would be necessary.

  mysys/my_static.h@stripped, 2008-04-07 05:10:19+02:00, tnurnberg@stripped +1 -1
    Make memory-accounting 64-bit safe.

diff -Nrup a/mysys/my_static.h b/mysys/my_static.h
--- a/mysys/my_static.h	2004-05-26 18:12:46 +02:00
+++ b/mysys/my_static.h	2008-04-07 05:10:19 +02:00
@@ -46,7 +46,7 @@ struct st_irem
   struct st_irem *prev;		/* Other link			   */
   char *filename;		/* File in which memory was new'ed */
   uint32 linenum;		/* Line number in above file	   */
-  uint32 datasize;		/* Size requested		   */
+  size_t datasize;		/* Size requested		   */
   uint32 SpecialValue;		/* Underrun marker value	   */
 };
 
Thread
bk commit into 4.1 tree (tnurnberg:1.2714) BUG#35616Tatjana A Nuernberg7 Apr