Hi, Mats.
Thanks for review!
Wrote following comment:
The reason of bug is incorrect clean up during restarting of mysqld under
Windows platform (seems some files were in-use).
Mtr restarts servers because an option file exist for slave.
The option file for slave forces to skip test.foo table for replication.
But really test case does not involved test.foo table at all.
So option file can be removed and mtr will not restart servers for
test case.
Mats Kindahl wrote:
> Hi Serge!
>
> A minor comment on the cset comment, otherwise the patch is good. I'll
> approve the comment, but I expect that you extend the comment before
> pushing the patch.
>
> /Matz
>
> Serge Kozlov wrote:
>> Below is the list of changes that have just been committed into a local
>> 5.0 repository of skozlov. When skozlov does a push these changes
>> will be propagated to the main repository and, within 24 hours after the
>> push, to the public repository.
>> For information on how to access the public repository
>> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>>
>> ChangeSet@stripped, 2008-04-04 15:13:12+04:00, skozlov@stripped +2 -0
>> Bug#32654, removed option file for slave
>>
>
> Could you please add reason that the option file can be removed: just
> something as simple as "option file removed since test does not involve
> a table test.foo at all." I don't think it is necessary to tell why the
> failure occurs in this case.
>
>> BitKeeper/deleted/.del-rpl_view-slave.opt@stripped, 2008-04-04
>> 15:11:47+04:00, skozlov@stripped +0 -0
>> Delete: mysql-test/t/rpl_view-slave.opt
>>
>> mysql-test/t/disabled.def@stripped, 2008-04-04 15:13:10+04:00,
>> skozlov@stripped +0 -1
>> updated
>>
>> diff -Nrup a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def
>> --- a/mysql-test/t/disabled.def 2007-11-28 11:48:04 +03:00
>> +++ b/mysql-test/t/disabled.def 2008-04-04 15:13:10 +04:00
>> @@ -18,7 +18,6 @@ im_options_unset : Bug#20294: Instan
>> im_utils : Bug#20294: Instance manager tests fail randomly
>> grant_cache : Bug#32651: grant_cache.test fails
>> rpl_log : Bug#32653: rpl_log.test fails randomly
>> -rpl_view : Bug#32654: rpl_view.test fails randomly
>> ndb_backup_print : Bug#32357: ndb_backup_print test fails
>> sometimes in pushbuild
>> rpl_log_pos : Bug#8693 Test 'rpl_log_pos' fails sometimes
>> kill : Bug#29149 Test "kill" fails on Windows
>> diff -Nrup a/mysql-test/t/rpl_view-slave.opt
>> b/mysql-test/t/rpl_view-slave.opt
>> --- a/mysql-test/t/rpl_view-slave.opt 2006-04-14 13:13:21 +04:00
>> +++ /dev/null Wed Dec 31 16:00:00 196900
>> @@ -1 +0,0 @@
>> ---replicate-ignore-table=test.foo
>>
>>
>
>
--
Serge Kozlov, QA Developer
MySQL AB, Moscow, Russia, www.mysql.com
Office:
Are you MySQL certified? www.mysql.com/certification
