From: Date: April 6 2008 7:34pm
Subject: Re: bk commit into 5.0 tree (skozlov:1.2611) BUG#32654
List-Archive: http://lists.mysql.com/commits/44962
Message-Id: <47F909BD.6050302@mysql.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------060509080905060507060802"

--------------060509080905060507060802
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Serge!

A minor comment on the cset comment, otherwise the patch is good. I'll 
approve the comment, but I expect that you extend the comment before 
pushing the patch.

/Matz

Serge Kozlov wrote:
> Below is the list of changes that have just been committed into a local
> 5.0 repository of skozlov.  When skozlov does a push these changes
> will be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2008-04-04 15:13:12+04:00, skozlov@stripped +2 -0
>   Bug#32654, removed option file for slave
>   

Could you please add reason that the option file can be removed: just 
something as simple as "option file removed since test does not involve 
a table test.foo at all." I don't think it is necessary to tell why the 
failure occurs in this case.

>   BitKeeper/deleted/.del-rpl_view-slave.opt@stripped, 2008-04-04 15:11:47+04:00, skozlov@stripped +0 -0
>     Delete: mysql-test/t/rpl_view-slave.opt
>
>   mysql-test/t/disabled.def@stripped, 2008-04-04 15:13:10+04:00, skozlov@stripped +0 -1
>     updated
>
> diff -Nrup a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def
> --- a/mysql-test/t/disabled.def	2007-11-28 11:48:04 +03:00
> +++ b/mysql-test/t/disabled.def	2008-04-04 15:13:10 +04:00
> @@ -18,7 +18,6 @@ im_options_unset     : Bug#20294: Instan
>  im_utils             : Bug#20294: Instance manager tests fail randomly
>  grant_cache          : Bug#32651: grant_cache.test fails
>  rpl_log              : Bug#32653: rpl_log.test fails randomly
> -rpl_view             : Bug#32654: rpl_view.test fails randomly
>  ndb_backup_print     : Bug#32357: ndb_backup_print test fails sometimes in pushbuild
>  rpl_log_pos          : Bug#8693 Test 'rpl_log_pos' fails sometimes
>  kill                 : Bug#29149 Test "kill" fails on Windows
> diff -Nrup a/mysql-test/t/rpl_view-slave.opt b/mysql-test/t/rpl_view-slave.opt
> --- a/mysql-test/t/rpl_view-slave.opt	2006-04-14 13:13:21 +04:00
> +++ /dev/null	Wed Dec 31 16:00:00 196900
> @@ -1 +0,0 @@
> ---replicate-ignore-table=test.foo
>
>   


-- 
Mats Kindahl
Lead Software Developer
Replication Team
MySQL AB, www.mysql.com


--------------060509080905060507060802--