bk commit into 5.1 tree (mtaylor:1.2569) BUG#34639

[Monty Taylor]

Below is the list of changes that have just been committed into a local
5.1 repository of mtaylor.  When mtaylor does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-04-05 18:39:41+02:00, mtaylor@solace.(none) +9 -0
  BUG#34639 useless linkages
  
  Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
  places and don't need to be linked by every program.

  client/Makefile.am@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +1 -0
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  config/ac-macros/zlib.m4@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +2 -1
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  configure.in@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +17 -2
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  libmysql/Makefile.am@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +1 -1
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  libmysql_r/Makefile.am@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +1 -1
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  mysys/Makefile.am@stripped, 2008-04-05 18:39:38+02:00, mtaylor@solace.(none) +1 -1
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  sql/Makefile.am@stripped, 2008-04-05 18:39:39+02:00, mtaylor@solace.(none) +1 -0
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  storage/myisam/Makefile.am@stripped, 2008-04-05 18:39:39+02:00, mtaylor@solace.(none) +9 -9
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

  unittest/mysys/Makefile.am@stripped, 2008-04-05 18:39:39+02:00, mtaylor@solace.(none) +2 -1
    BUG#34639 useless linkages
    
    Split M, Z, CRYPT and NSL libs out from LIBS, as they are only used in one or two 
    places and don't need to be linked by every program.

diff -Nrup a/client/Makefile.am b/client/Makefile.am
--- a/client/Makefile.am	2007-11-01 16:49:37 +01:00
+++ b/client/Makefile.am	2008-04-05 18:39:38 +02:00
@@ -54,6 +54,7 @@ bin_PROGRAMS =			mysql \
 mysql_SOURCES =			mysql.cc readline.cc sql_string.cc \
 				completion_hash.cc
 mysql_LDADD =			@readline_link@ @TERMCAP_LIB@ \
+				@ZLIB_LIBS@ \
 				$(LDADD) $(CXXLDFLAGS)
 mysqladmin_SOURCES =		mysqladmin.cc
 
diff -Nrup a/config/ac-macros/zlib.m4 b/config/ac-macros/zlib.m4
--- a/config/ac-macros/zlib.m4	2007-08-31 01:18:56 +02:00
+++ b/config/ac-macros/zlib.m4	2008-04-05 18:39:38 +02:00
@@ -19,7 +19,8 @@ AC_DEFUN([MYSQL_CHECK_ZLIB_DIR], [
 save_CPPFLAGS="$CPPFLAGS"
 save_LIBS="$LIBS"
 CPPFLAGS="$ZLIB_INCLUDES $CPPFLAGS"
-LIBS="$LIBS $ZLIB_LIBS"
+#We don't really need this everywhere. Use ZLIB_LIBS in Makefiles.
+#LIBS="$LIBS $ZLIB_LIBS"
 if test X"$with_server" = Xno
 then
   zlibsym=zlibVersion
diff -Nrup a/configure.in b/configure.in
--- a/configure.in	2008-03-31 19:04:53 +02:00
+++ b/configure.in	2008-04-05 18:39:38 +02:00
@@ -833,20 +833,32 @@ AC_CHECK_HEADERS([xfs/xfs.h])
 # and defines HAVE_LIBM etc
 #--------------------------------------------------------------------
 
+_libs=${LIBS}
+LIBS=''
 AC_CHECK_LIB(m, floor, [], AC_CHECK_LIB(m, __infinity))
+M_LIBS=${LIBS}
+LIBS=${_libs}
 
+_libs=${LIBS}
+LIBS=''
 AC_CHECK_LIB(nsl_r, gethostbyname_r, [],
   AC_CHECK_LIB(nsl, gethostbyname_r))
 AC_CHECK_FUNC(gethostbyname_r)
-
-AC_CHECK_FUNC(setsockopt, , AC_CHECK_LIB(socket, setsockopt))
 AC_CHECK_FUNC(yp_get_default_domain, ,
   AC_CHECK_LIB(nsl, yp_get_default_domain))
+NSL_LIBS=${LIBS}
+LIBS=${_libs}
+
+AC_CHECK_FUNC(setsockopt, , AC_CHECK_LIB(socket, setsockopt))
 AC_CHECK_FUNC(p2open, , AC_CHECK_LIB(gen, p2open))
 # This may get things to compile even if bind-8 is installed
 AC_CHECK_FUNC(bind, , AC_CHECK_LIB(bind, bind))
 # Check if crypt() exists in libc or libcrypt, sets LIBS if needed
+_libs=${LIBS}
+LIBS=''
 AC_SEARCH_LIBS(crypt, crypt, AC_DEFINE(HAVE_CRYPT, 1, [crypt]))
+CRYPT_LIBS=${LIBS}
+LIBS=${_libs}
 # See if we need a library for address lookup.
 AC_SEARCH_LIBS(inet_aton, [socket nsl resolv])
 
@@ -2673,6 +2685,9 @@ sql_client_dirs="$sql_client_dirs client
 
 CLIENT_LIBS="$NON_THREADED_LIBS $openssl_libs $ZLIB_LIBS $STATIC_NSS_FLAGS"
 
+AC_SUBST(M_LIBS)
+AC_SUBST(CRYPT_LIBS)
+AC_SUBST(NSL_LIBS)
 AC_SUBST(CLIENT_LIBS)
 AC_SUBST(CLIENT_THREAD_LIBS)
 AC_SUBST(NON_THREADED_LIBS)
diff -Nrup a/libmysql/Makefile.am b/libmysql/Makefile.am
--- a/libmysql/Makefile.am	2007-11-22 12:34:11 +01:00
+++ b/libmysql/Makefile.am	2008-04-05 18:39:38 +02:00
@@ -22,7 +22,7 @@
 
 target =	libmysqlclient.la
 target_defs =	-DUNDEF_THREADS_HACK -DDONT_USE_RAID @LIB_EXTRA_CCFLAGS@
-LIBS =		@CLIENT_LIBS@ 
+LIBS =		@CLIENT_LIBS@  @M_LIBS@
 INCLUDES =	-I$(top_builddir)/include -I$(top_srcdir)/include \
 		$(openssl_includes) @ZLIB_INCLUDES@
 
diff -Nrup a/libmysql_r/Makefile.am b/libmysql_r/Makefile.am
--- a/libmysql_r/Makefile.am	2007-10-08 20:55:22 +02:00
+++ b/libmysql_r/Makefile.am	2008-04-05 18:39:38 +02:00
@@ -22,7 +22,7 @@
 
 target = libmysqlclient_r.la
 target_defs = -DDONT_USE_RAID -DMYSQL_CLIENT @LIB_EXTRA_CCFLAGS@
-LIBS = @LIBS@ @ZLIB_LIBS@ @openssl_libs@
+LIBS = @LIBS@ @ZLIB_LIBS@ @openssl_libs@ @M_LIBS@
 
 INCLUDES =	-I$(top_builddir)/include -I$(top_srcdir)/include \
 		$(openssl_includes) @ZLIB_INCLUDES@
diff -Nrup a/mysys/Makefile.am b/mysys/Makefile.am
--- a/mysys/Makefile.am	2008-03-28 20:08:26 +01:00
+++ b/mysys/Makefile.am	2008-04-05 18:39:38 +02:00
@@ -57,7 +57,7 @@ EXTRA_DIST =		thr_alarm.c thr_lock.c my_
 			thr_mutex.c thr_rwlock.c \
 			CMakeLists.txt mf_soundex.c \
 			my_conio.c my_wincond.c my_winthread.c
-libmysys_a_LIBADD =	@THREAD_LOBJECTS@
+libmysys_a_LIBADD =	@THREAD_LOBJECTS@ 
 # test_dir_DEPENDENCIES=	$(LIBRARIES)
 # testhash_DEPENDENCIES=	$(LIBRARIES)
 # test_charset_DEPENDENCIES=	$(LIBRARIES)
diff -Nrup a/sql/Makefile.am b/sql/Makefile.am
--- a/sql/Makefile.am	2008-03-06 16:12:59 +01:00
+++ b/sql/Makefile.am	2008-04-05 18:39:39 +02:00
@@ -43,6 +43,7 @@ mysqld_LDADD =		libndb.la \
 			@MYSQLD_EXTRA_LDFLAGS@ \
 			@pstack_libs@ \
 			@mysql_plugin_libs@ \
+			@CRYPT_LIBS@ \
 			$(LDADD)  $(CXXLDFLAGS) $(WRAPLIBS) @LIBDL@ \
 			$(yassl_libs) $(openssl_libs) @MYSQLD_EXTRA_LIBS@
 
diff -Nrup a/storage/myisam/Makefile.am b/storage/myisam/Makefile.am
--- a/storage/myisam/Makefile.am	2006-12-31 01:06:39 +01:00
+++ b/storage/myisam/Makefile.am	2008-04-05 18:39:39 +02:00
@@ -36,17 +36,17 @@ myisamchk_DEPENDENCIES=	$(LIBRARIES)
 myisamchk_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 myisamlog_DEPENDENCIES=	$(LIBRARIES)
 myisamlog_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 myisampack_DEPENDENCIES=$(LIBRARIES)
 myisampack_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 noinst_PROGRAMS =	mi_test1 mi_test2 mi_test3 rt_test sp_test #ft_test1 ft_eval
 noinst_HEADERS =	myisamdef.h rt_index.h rt_key.h rt_mbr.h sp_defs.h \
 			fulltext.h ftdefs.h ft_test1.h ft_eval.h \
@@ -55,34 +55,34 @@ mi_test1_DEPENDENCIES=	$(LIBRARIES)
 mi_test1_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 mi_test2_DEPENDENCIES=	$(LIBRARIES)
 mi_test2_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 mi_test3_DEPENDENCIES=	$(LIBRARIES)
 mi_test3_LDADD=		@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 #ft_test1_DEPENDENCIES=	$(LIBRARIES)
 #ft_eval_DEPENDENCIES=	$(LIBRARIES)
 myisam_ftdump_DEPENDENCIES=	$(LIBRARIES)
 myisam_ftdump_LDADD =			@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 rt_test_DEPENDENCIES=	$(LIBRARIES)
 rt_test_LDADD =			@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 sp_test_DEPENDENCIES=	$(LIBRARIES)
 sp_test_LDADD =			@CLIENT_EXTRA_LDFLAGS@ libmyisam.a \
 			$(top_builddir)/mysys/libmysys.a \
 			$(top_builddir)/dbug/libdbug.a \
-			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@
+			$(top_builddir)/strings/libmystrings.a @ZLIB_LIBS@ @M_LIBS@
 libmyisam_a_SOURCES =	mi_open.c mi_extra.c mi_info.c mi_rkey.c \
 			mi_rnext.c mi_rnext_same.c \
 			mi_search.c mi_page.c mi_key.c mi_locking.c \
diff -Nrup a/unittest/mysys/Makefile.am b/unittest/mysys/Makefile.am
--- a/unittest/mysys/Makefile.am	2007-05-28 22:17:46 +02:00
+++ b/unittest/mysys/Makefile.am	2008-04-05 18:39:39 +02:00
@@ -19,7 +19,8 @@ AM_CPPFLAGS     += -I$(top_srcdir)/inclu
 LDADD 		= $(top_builddir)/unittest/mytap/libmytap.a \
 		  $(top_builddir)/mysys/libmysys.a \
 		  $(top_builddir)/dbug/libdbug.a \
-		  $(top_builddir)/strings/libmystrings.a
+		  $(top_builddir)/strings/libmystrings.a \
+		  @M_LIBS@
 
 noinst_PROGRAMS  = bitmap-t base64-t my_atomic-t