Re: bk commit into 5.1 tree (skozlov:1.2567), please review

[Sven Sandberg]

Ingo Strüwing wrote:
> Hi Serge, Sven,
> 
> Serge Kozlov, 31.03.2008 15:49:
> ...
>> Sven Sandberg wrote:
> ...
>>> Serge Kozlov wrote:
>>> [...]
>>>> diff -Nrup a/mysql-test/include/circular_rpl_for_4_hosts_init.inc
>>>> b/mysql-test/include/circular_rpl_for_4_hosts_init.inc
>>>> --- /dev/null    Wed Dec 31 16:00:00 196900
>>>> +++ b/mysql-test/include/circular_rpl_for_4_hosts_init.inc   
>>>> 2008-03-20 23:42:51 +03:00
>>>> @@ -0,0 +1,130 @@
>>>> +#############################################################
>>>> +#
>>>> +# Author:  Serge Kozlov <skozlov@stripped>
>>>> +# Date:    03/11/2008
>>> I think author and date should not be included - you can use 'bk
>>> annotate' to find out. Author and time usually change over time.
>> skozlov:
>> It is impossible when tests are part of binary distribution so I add
>> additional info at beginning of test. Also sometimes tests are not in bk
>> and header helps in this case.
> 
> What a pity that our fine documents seem to be a secret. ;-(
> Please see
> http://dev.mysql.com/doc/mysqltest/en/tutorial-coding-guidelines.html

Wow, I had no idea that page existed. Unfortunately, it seems we have 
two manuals for the test framework (the other one at 
https://inside.mysql.com/wiki/MySQLTestManual). Of course I didn't 
expect there to be another one and stopped when I found the first one 
(which happened to be the one on the wiki). So the one you link to was 
hidden by the wiki manual for me.

The manual you link to seems to be much more complete and organized than 
the one on wiki. To make it easier to find and maintain the manual, can 
we please remove or deprecate one of them? Preferably the one on wiki?

I would have expected code guidelines for tests to be together with code 
guidelines for C++ 
(http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines), which 
they were not. I'll add a link from there.

-- 
Sven Sandberg, Software Engineer
MySQL AB, www.mysql.com