Re: bk commit into 5.1 tree (skozlov:1.2567), please review

[Ingo Strüwing]

Hi Serge, Sven,

Serge Kozlov, 31.03.2008 15:49:
...
> Sven Sandberg wrote:
...
>> Serge Kozlov wrote:
>> [...]
>>> diff -Nrup a/mysql-test/include/circular_rpl_for_4_hosts_init.inc
>>> b/mysql-test/include/circular_rpl_for_4_hosts_init.inc
>>> --- /dev/null    Wed Dec 31 16:00:00 196900
>>> +++ b/mysql-test/include/circular_rpl_for_4_hosts_init.inc   
>>> 2008-03-20 23:42:51 +03:00
>>> @@ -0,0 +1,130 @@
>>> +#############################################################
>>> +#
>>> +# Author:  Serge Kozlov <skozlov@stripped>
>>> +# Date:    03/11/2008
>>
>> I think author and date should not be included - you can use 'bk
>> annotate' to find out. Author and time usually change over time.
> 
> skozlov:
> It is impossible when tests are part of binary distribution so I add
> additional info at beginning of test. Also sometimes tests are not in bk
> and header helps in this case.

What a pity that our fine documents seem to be a secret. ;-(
Please see
http://dev.mysql.com/doc/mysqltest/en/tutorial-coding-guidelines.html

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140