List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:March 31 2008 3:48pm
Subject:Re: bk commit into 5.0 tree (malff:1.2604) BUG#31767
View as plain text  
Hi Marc,

First, why you think this is 5.0 material?

marc.alff@stripped wrote:
> Below is the list of changes that have just been committed into a local
> 5.0 repository of malff.  When malff does a push these changes
> will be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> 
> ChangeSet@stripped, 2008-03-12 18:03:23-06:00, malff@stripped. +9 -0
>   Bug#31767 (DROP FUNCTION name resolution)

Out of curiosity, any reason for the parenthesis?

>   Before this fix,
>   DROP FUNCTION <db>.<name> could drop a user defined function named
> <name>.
>   
>   The resolution of a <name> to either a UDF or a stored function was
>   different in the following statements:
>   - DROP FUNCTION <name>
>   - SELECT <name>(...)
>   
>   With this fix, the implementation of DROP FUNCTION has been changed,
>   so that:
>   - DROP FUNCTION <db>.<name> only drop the stored function
> <db>.<name>
>   - DROP FUNCTION <name> resolve the <name> using rules consistent
>   with the SELECT <name>() statement.

As I understand it, DROP FUNCTION is used to drop stored functions and
user-defined functions. When passing a fully qualified name (db.name),
it drops stored functions because we can't have UDF's with such names.
When passing a non-qualified name, it tries to drop a user-defined
function and if one is not found, it tries to drop a stored function.

Could you mention these rules in the changeset comment? We need to
document this in the description of the DROP FUNCTION statement.

[..]

Otherwise, looks good. Approved, we only need to decided in which tree
to push.

Regards,

-- 
Davi Arnaut, Software Engineer
MySQL Inc, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification
Thread
bk commit into 5.0 tree (malff:1.2604) BUG#31767marc.alff13 Mar
  • Re: bk commit into 5.0 tree (malff:1.2604) BUG#31767Davi Arnaut31 Mar