List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:March 31 2008 12:44pm
Subject:Re: bk commit into 5.1 tree (davi:1.2572)
View as plain text  
* Davi Arnaut <davi@stripped> [08/03/26 02:13]:
> ChangeSet@stripped, 2008-03-25 20:48:20-03:00, davi@stripped +1 -0
>   Post-merge fixes for bug 35103
>   
>   Don't signal errors for the COM_STMT_SEND_LONG_DATA
>   and COM_STMT_CLOSE commands.

OK to push.

> @@ -2633,17 +2650,13 @@ void mysql_stmt_get_longdata(THD *thd, c
>  #ifndef EMBEDDED_LIBRARY
>    /* Minimal size of long data packet is 6 bytes */
>    if (packet_length < MYSQL_LONG_DATA_HEADER)
> -  {
> -    my_error(ER_WRONG_ARGUMENTS, MYF(0), "mysql_stmt_send_long_data");
>      DBUG_VOID_RETURN;
> -  }
>  #endif
>  
>    stmt_id= uint4korr(packet);
>    packet+= 4;
>  
> -  if (!(stmt=find_prepared_statement(thd, stmt_id,
> -                                     "mysql_stmt_send_long_data")))
> +  if (!(stmt=find_prepared_statement(thd, stmt_id)))
>      DBUG_VOID_RETURN;
>  
>    param_number= uint2korr(packet);

OK, but please also move disable_status() call to the end of this
function.


Thank you for looking at this!

-- 
Konstantin
Thread
bk commit into 5.1 tree (davi:1.2572)Davi Arnaut26 Mar
  • Re: bk commit into 5.1 tree (davi:1.2572)Paul DuBois26 Mar
    • Re: bk commit into 5.1 tree (davi:1.2572)Davi Arnaut26 Mar
  • Re: bk commit into 5.1 tree (davi:1.2572)Konstantin Osipov31 Mar