List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:March 28 2008 4:22pm
Subject:Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068
View as plain text  
Ingo Strüwing wrote:
> Thank you.
>
> So you seem to agree with me that it is better to have more specific
> error messages and that the security concern from Serg, reported by Svoj
> and seconded by Gluh is not valid here? (Just asking to avoid an oversight).
>   
I will need to see the report from Svoj before I can form an opinion on 
that. (I am new to information_schema after all) By the time I decided 
to approve, the patch was in 'PA' state.

>> IMHO the above information would be helpful if it were included in the
>> comment to get_all_tables() as well.
>>     
>
> Ok. OTOH, if you support the error message concern, one might be able to
> fix the bug in get_all_tables() by checking for thd->open_tables in
> addition to ER_NO_SUCH_TABLE.
>   
This makes sense. But as stated above, I haven't seen Svoj's email, so I 
can't really answer that. If you want my opinion, please forward the 
mail to me.
>> I'd say "parent's TABLE" here...
>>     
>
> Ok. I googled around as there seems to be some confusion around
> apostrophe usage. But the vast majority of authors agrees with you. So
> I'll try to change my habits in the future.
>   
This is genitive case, as in "the table belonging to the parent", if I 
understood correctly. See 
http://en.wikipedia.org/wiki/Genitive#The_English_-.27s_ending

Best Regards

Martin
Thread
bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Ingo Struewing18 Mar
  • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Martin Hansson24 Mar
    • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Ingo Strüwing25 Mar
      • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Martin Hansson28 Mar