bk commit into 4.1 tree (mattiasj:1.2707) BUG#21413

[mattiasj]

Below is the list of changes that have just been committed into a local
4.1 repository of mattiasj. When mattiasj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-03-28 14:27:22+01:00, mattiasj@witty. +1 -0
  Bug#21413 - Engine table handler used by multiple threads
              in REPLACE DELAYED
      
  post push patch, removing the optimization for
  copying delayed_insert variables.

  sql/sql_insert.cc@stripped, 2008-03-28 14:27:21+01:00, mattiasj@witty. +2 -3
    Bug#21413 - Engine table handler used by multiple threads
                in REPLACE DELAYED
    
    post push patch, removing the optimization for
    copying delayed_insert variables.
    (restored some parts which caused errors)

diff -Nrup a/sql/sql_insert.cc b/sql/sql_insert.cc
--- a/sql/sql_insert.cc	2008-03-27 01:13:38 +01:00
+++ b/sql/sql_insert.cc	2008-03-28 14:27:21 +01:00
@@ -941,11 +941,10 @@ static TABLE *delayed_get_table(THD *thd
 	my_error(ER_OUT_OF_RESOURCES,MYF(0));
 	goto err1;
       }
-      /* We only need the db and table name to open tables with open_ltable() */
+      tmp->table_list= *table_list;			// Needed to open table
+      /* Replace volatile strings with local copies */
       tmp->table_list.db= tmp->thd.db;
-      tmp->table_list.db_length= table_list->db_length;
       tmp->table_list.alias= tmp->table_list.real_name=tmp->thd.query;
-      tmp->table_list.real_name_length= table_list->real_name_length;
       tmp->lock();
       pthread_mutex_lock(&tmp->mutex);
       if ((error=pthread_create(&tmp->thd.real_id,&connection_attrib,