From: Date: March 27 2008 5:43pm
Subject: bk commit into 5.1 tree (tnurnberg:1.2573) BUG#35272
List-Archive: http://lists.mysql.com/commits/44521
X-Bug: 35272
Message-Id: <200803271643.m2RGhLfU024394@white.intern.koehntopp.de>

Below is the list of changes that have just been committed into a local
5.1 repository of tnurnberg.  When tnurnberg does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-03-27 17:43:17+01:00, tnurnberg@stripped +2 -0
  Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash
  
  reverting test that has been obsoleted by changes to the code

  mysql-test/r/key_cache.result@stripped, 2008-03-27 17:43:16+01:00, tnurnberg@stripped +0 -5
    reverting test that has been obsoleted by changes to the code

  mysql-test/t/key_cache.test@stripped, 2008-03-27 17:43:16+01:00, tnurnberg@stripped +0 -25
    reverting test that has been obsoleted by changes to the code

diff -Nrup a/mysql-test/r/key_cache.result b/mysql-test/r/key_cache.result
--- a/mysql-test/r/key_cache.result	2008-03-25 19:53:54 +01:00
+++ b/mysql-test/r/key_cache.result	2008-03-27 17:43:16 +01:00
@@ -368,8 +368,3 @@ Variable_name	Value
 key_cache_block_size	1536
 SET GLOBAL key_cache_block_size= @bug28478_key_cache_block_size;
 DROP TABLE t1;
-SET @save_key_buffer = @@global.key_buffer_size;
-SET @@global.key_buffer_size = 4294967295;
-SET @@global.key_buffer_size = 9223372036854775807;
-SET @@global.key_buffer_size = @save_key_buffer;
-End of 5.1 tests
diff -Nrup a/mysql-test/t/key_cache.test b/mysql-test/t/key_cache.test
--- a/mysql-test/t/key_cache.test	2008-03-25 19:53:55 +01:00
+++ b/mysql-test/t/key_cache.test	2008-03-27 17:43:16 +01:00
@@ -247,28 +247,3 @@ SET GLOBAL key_cache_block_size= @bug284
 DROP TABLE t1;
 
 # End of 4.1 tests
-
-#
-# Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash
-#
-
-SET @save_key_buffer = @@global.key_buffer_size;
-
-# Wee try to force Out Of Memory here. key_buffer_size is ULL, so
-# on a 32 bit machine, 4GB is the most we can ask for before the
-# server complains about value/variable mismatch. At the off chance
-# of one of our 64-bit machines actually offering us 4GB, we also
-# accept "no error" (in addition to the expected "out of memory").
---error 0,ER_OUTOFMEMORY
-SET @@global.key_buffer_size = 4294967295;
-
-# on 32-bit, we get "out of range", on 64-bit, "out of memory".
---error 0,ER_WRONG_ARGUMENTS,ER_OUTOFMEMORY
---disable_warnings
-SET @@global.key_buffer_size = 9223372036854775807;
---enable_warnings
-
-# restore normal value, just in case we got the 4GB or something.
-SET @@global.key_buffer_size = @save_key_buffer;
-
---echo End of 5.1 tests