Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068

[Ingo Strüwing]

Hi Martin,

Martin Hansson, 24.03.2008 11:40:
> Hi Ingo,
> I approve this patch. Just some thoughts below. I let you decide whether
> to act upon them or not.

Thank you.

So you seem to agree with me that it is better to have more specific
error messages and that the security concern from Serg, reported by Svoj
and seconded by Gluh is not valid here? (Just asking to avoid an oversight).

...
> Ingo Struewing wrote:
>>     get_all_tables() from information schema assumes that it opens
>>   one table at a time. If it cannot be opened, and the error is
>>   ER_NO_SUCH_TABLE, it assumes that no table needs to be closed.
>>   
> IMHO the above information would be helpful if it were included in the
> comment to get_all_tables() as well.

Ok. OTOH, if you support the error message concern, one might be able to
fix the bug in get_all_tables() by checking for thd->open_tables in
addition to ER_NO_SUCH_TABLE.

>> +    /*
>> +      If the error happened on a MERGE child, clear the parents TABLE
>>   
> I'd say "parent's TABLE" here...

Ok. I googled around as there seems to be some confusion around
apostrophe usage. But the vast majority of authors agrees with you. So
I'll try to change my habits in the future.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140